diff mbox

[U-Boot] imx: nitrogen6x: Replace 'fatload' by 'load' command in env settings to be filesystem independent

Message ID 1409047531-5016-1-git-send-email-guillaume.gardet@free.fr
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Guillaume GARDET Aug. 26, 2014, 10:05 a.m. UTC
nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
'load' command instead of 'fatload'. It allows to use ext filesystem and keep
compatibilty with fat filesystem.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Cc: Stefano Babic <sbabic@denx.de>
 
---
 include/configs/nitrogen6x.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Fabio Estevam Sept. 1, 2014, 2:24 a.m. UTC | #1
On Tue, Aug 26, 2014 at 7:05 AM, Guillaume GARDET
<guillaume.gardet@free.fr> wrote:
> nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
> 'load' command instead of 'fatload'. It allows to use ext filesystem and keep
> compatibilty with fat filesystem.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>

Adding Eric Nelson on Cc.

> ---
>  include/configs/nitrogen6x.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index b2b17ce..d4b0ac9 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -192,11 +192,11 @@
>         "mmcargs=setenv bootargs console=${console},${baudrate} " \
>                 "root=${mmcroot}\0" \
>         "loadbootscript=" \
> -               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> +               "load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>         "bootscript=echo Running bootscript from mmc ...; " \
>                 "source\0" \
> -       "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
> -       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
> +       "loaduimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
> +       "loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>         "mmcboot=echo Booting from mmc ...; " \
>                 "run mmcargs; " \
>                 "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
> --
> 1.8.4.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Eric Nelson Sept. 1, 2014, 6:27 p.m. UTC | #2
Hi all,

On 08/31/2014 07:24 PM, Fabio Estevam wrote:
> On Tue, Aug 26, 2014 at 7:05 AM, Guillaume GARDET
> <guillaume.gardet@free.fr> wrote:
>> nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
>> 'load' command instead of 'fatload'. It allows to use ext filesystem and keep
>> compatibilty with fat filesystem.
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>> Cc: Stefano Babic <sbabic@denx.de>
> 
> Adding Eric Nelson on Cc.
> 

Thanks Fabio. I stopped delivery from the list while on vacation and
hadn't re-started it.

>> ---
>>  include/configs/nitrogen6x.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
>> index b2b17ce..d4b0ac9 100644
>> --- a/include/configs/nitrogen6x.h
>> +++ b/include/configs/nitrogen6x.h
>> @@ -192,11 +192,11 @@

I've been wondering if anyone was using this section of nitrogen6x.h,
and I guess this answers the question.

>>         "mmcargs=setenv bootargs console=${console},${baudrate} " \
>>                 "root=${mmcroot}\0" \
>>         "loadbootscript=" \
>> -               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>> +               "load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>         "bootscript=echo Running bootscript from mmc ...; " \
>>                 "source\0" \
>> -       "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>> -       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>> +       "loaduimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>> +       "loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>>         "mmcboot=echo Booting from mmc ...; " \
>>                 "run mmcargs; " \
>>                 "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
>> --
>> 1.8.4.5
>>
I don't have a copy of the original e-mail, but:

Acked-By: Eric Nelson <eric.nelson@boundarydevices.com>
Guillaume GARDET Sept. 9, 2014, 12:31 p.m. UTC | #3
Ping.

Guillaume


Le 01/09/2014 20:27, Eric Nelson a écrit :
> Hi all,
>
> On 08/31/2014 07:24 PM, Fabio Estevam wrote:
>> On Tue, Aug 26, 2014 at 7:05 AM, Guillaume GARDET
>> <guillaume.gardet@free.fr> wrote:
>>> nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
>>> 'load' command instead of 'fatload'. It allows to use ext filesystem and keep
>>> compatibilty with fat filesystem.
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>> Cc: Stefano Babic <sbabic@denx.de>
>> Adding Eric Nelson on Cc.
>>
> Thanks Fabio. I stopped delivery from the list while on vacation and
> hadn't re-started it.
>
>>> ---
>>>   include/configs/nitrogen6x.h | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
>>> index b2b17ce..d4b0ac9 100644
>>> --- a/include/configs/nitrogen6x.h
>>> +++ b/include/configs/nitrogen6x.h
>>> @@ -192,11 +192,11 @@
> I've been wondering if anyone was using this section of nitrogen6x.h,
> and I guess this answers the question.
>
>>>          "mmcargs=setenv bootargs console=${console},${baudrate} " \
>>>                  "root=${mmcroot}\0" \
>>>          "loadbootscript=" \
>>> -               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>> +               "load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>>          "bootscript=echo Running bootscript from mmc ...; " \
>>>                  "source\0" \
>>> -       "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>>> -       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>>> +       "loaduimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>>> +       "loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
>>>          "mmcboot=echo Booting from mmc ...; " \
>>>                  "run mmcargs; " \
>>>                  "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
>>> --
>>> 1.8.4.5
>>>
> I don't have a copy of the original e-mail, but:
>
> Acked-By: Eric Nelson <eric.nelson@boundarydevices.com>
>
>
Stefano Babic Sept. 9, 2014, 12:38 p.m. UTC | #4
Hi Guillaume,

On 09/09/2014 14:31, Guillaume Gardet wrote:
> Ping.

Sorry, I was not in office in the last two weeks. I will go through all
i.MX patches (it seems I have something to do..) and I will apply the
ones are ready, as yours.

Best regards,
Stefano Babic
Stefano Babic Sept. 9, 2014, 2:58 p.m. UTC | #5
On 26/08/2014 12:05, Guillaume GARDET wrote:
> nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
> 'load' command instead of 'fatload'. It allows to use ext filesystem and keep
> compatibilty with fat filesystem.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>
>  
> ---


Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index b2b17ce..d4b0ac9 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -192,11 +192,11 @@ 
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=${mmcroot}\0" \
 	"loadbootscript=" \
-		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+		"load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
-	"loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loaduimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run mmcargs; " \
 		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \