From patchwork Thu Nov 12 17:09:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 38259 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 05166B7B69 for ; Fri, 13 Nov 2009 03:59:49 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N8czZ-0008Ql-S9; Thu, 12 Nov 2009 16:57:53 +0000 Received: from mail-qy0-f204.google.com ([209.85.221.204]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N8czT-0008GK-Fq for linux-mtd@lists.infradead.org; Thu, 12 Nov 2009 16:57:52 +0000 Received: by qyk42 with SMTP id 42so1081366qyk.28 for ; Thu, 12 Nov 2009 08:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=bSyPeFapYrybdDDCQO4dcweQqgTriGcyhUJg/eixCRY=; b=dRD9FGLkyYQltMfNxL93Hi1qNurx3albxko55vI4BwTUnIubuG+2SPXe0LjDUCs+/7 Zy5/g5pric4O8nW4NayZCWwoRCBEMVko6IFckZCj0tF9rjlpduAi7QgPedPjmY5SnVrU 8ewkPIH+cRdsSrHzY3lOWU9EGtJVaFapBSius= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=orxFOLuKC9Nia/jkMAa3LqDGuG2cWEHJR3IUPal9IM+NeB86w4Rx81DayG6JWB5sP5 7CfuqhiPU8BdSv0Z7CLxSzvWqTis+0H/y/njIeOf/5RxlDbufI+yFvRHMCd6R8MRYyDF tlZzlWFrfIU8ZrWWgY7jmgyLP0HMfvMQyPzAA= Received: by 10.213.96.83 with SMTP id g19mr2662729ebn.20.1258045064917; Thu, 12 Nov 2009 08:57:44 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 10sm1217030eyz.35.2009.11.12.08.57.43 (version=SSLv3 cipher=RC4-MD5); Thu, 12 Nov 2009 08:57:43 -0800 (PST) Message-ID: <4AFC415C.6040305@gmail.com> Date: Thu, 12 Nov 2009 18:09:48 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: David Woodhouse , linux-mtd@lists.infradead.org, Andrew Morton , LKML Subject: [PATCH] jffs2: Fix error return in jffs2_do_read_inode_internal() X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091112_115747_741730_4E20EED9 X-CRM114-Status: GOOD ( 19.57 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The returned error should stay negative Signed-off-by: Roel Kluin --- fs/jffs2/readinode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c index 1a80301..9c26738 100644 --- a/fs/jffs2/readinode.c +++ b/fs/jffs2/readinode.c @@ -1284,7 +1284,7 @@ static int jffs2_do_read_inode_internal(struct jffs2_sb_info *c, f->target = NULL; mutex_unlock(&f->sem); jffs2_do_clear_inode(c, f); - return -ret; + return ret; } f->target[je32_to_cpu(latest_node->csize)] = '\0';