Message ID | 1258042401.7727.3.camel@localhost.localdomain |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
From: Don Fry <pcnet32@verizon.net> Date: Thu, 12 Nov 2009 08:13:21 -0800 > I do not understand why you are suggesting this change. With NAPI > the amount of work done is returned on exit, not zero. All other > drivers I have looked at do not force a zero on exit. > > NAK Right, this change is completely wrong. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index c1b3f09..58894a3 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -1396,6 +1396,7 @@ static int pcnet32_poll(struct napi_struct *napi, int budget) spin_unlock_irqrestore(&lp->lock, flags); if (work_done < budget) { + work_done = 0; spin_lock_irqsave(&lp->lock, flags); __napi_complete(napi);