diff mbox

PR fortran/62245 fix INT docs.

Message ID 908103EDB4893A42920B21D3568BFD9312F37DC4@MBX23.d.ethz.ch
State New
Headers show

Commit Message

VandeVondele Joost Aug. 24, 2014, 12:37 p.m. UTC 
A doc change to refine wording for result value of int, avoiding the word range and using magnitude as does the standard. Mentions undefined behavior.

2014-08-24  Joost VandeVondele  <vondele@gcc.gnu.org>

	PR fortran/62245
	* intrinsic.texi (INT): clarify result and undefined behavior.

Comments

Gerald Pfeifer Aug. 24, 2014, 12:44 p.m. UTC | #1 
On Sun, 24 Aug 2014, VandeVondele  Joost wrote:
> A doc change to refine wording for result value of int, avoiding the 
> word range and using magnitude as does the standard. Mentions undefined 
> behavior.
> 
> 2014-08-24  Joost VandeVondele  <vondele@gcc.gnu.org>
> 
> 	PR fortran/62245
> 	* intrinsic.texi (INT): clarify result and undefined behavior.

Looks good to me, though better wait for a Fortran maintainer to be
sure.

One small ask:  these lines are too long (already before your patch);
can you please reformat those lines your patch touches to <80 columns?

Thanks,
gerald
diff mbox

Patch

Index: intrinsic.texi
===================================================================
--- intrinsic.texi	(revision 214408)
+++ intrinsic.texi	(working copy)
@@ -7371,8 +7371,10 @@  the following rules:
 If @var{A} is of type @code{INTEGER}, @code{INT(A) = A} 
 @item (B)
 If @var{A} is of type @code{REAL} and @math{|A| < 1}, @code{INT(A)} equals @code{0}. 
-If @math{|A| \geq 1}, then @code{INT(A)} equals the largest integer that does not exceed 
-the range of @var{A} and whose sign is the same as the sign of @var{A}.
+If @math{|A| \geq 1}, then @code{INT(A)} is the integer whose magnitude is the largest
+integer that does not exceed the magnitude of @var{A} and whose sign is the same as
+the sign of @var{A}. The result is undefined if it can not be represented as an
+@code{INTEGER} of the given @code{KIND}.
 @item (C)
 If @var{A} is of type @code{COMPLEX}, rule B is applied to the real part of @var{A}.
 @end table