| Message ID | 1408698774-13615-1-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Accepted |
| Commit | f8d4fe376cf65cc4e41423804869a79c2570f674 |
| Headers | show |
On Fri, Aug 22, 2014 at 11:12 AM, Romain Naour <romain.naour@openwide.fr> wrote: > On fedora 20 64bits host, the file /usr/share/config.site contains > a fix for installing libraries into /lib/lib64 on 64bits systems > that redefine libdir in the generated Makefile > > For safety and avoid the bug #7262 [1], disable loading this file > when running the configure script for the target and the host. > > Note: configure scripts generated with autoconf < 2.65 will source > the /dev/null and print this line: > "configure: loading site script /dev/null" > > [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Dear Romain Naour, On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote: > On fedora 20 64bits host, the file /usr/share/config.site contains > a fix for installing libraries into /lib/lib64 on 64bits systems > that redefine libdir in the generated Makefile > > For safety and avoid the bug #7262 [1], disable loading this file > when running the configure script for the target and the host. > > Note: configure scripts generated with autoconf < 2.65 will source > the /dev/null and print this line: > "configure: loading site script /dev/null" > > [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> I am wondering if this change should go in master (for 2014.08) or in the next branch (for 2014.11). That close to the release, doing a change in the core infrastructure seems a bit invasive to me. What if it breaks the build of other packages? Seems unlikely, I admit, but still. What do others think? Thanks! Thomas
Hi Thomas, Le 24/08/2014 18:14, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote: >> On fedora 20 64bits host, the file /usr/share/config.site contains >> a fix for installing libraries into /lib/lib64 on 64bits systems >> that redefine libdir in the generated Makefile >> >> For safety and avoid the bug #7262 [1], disable loading this file >> when running the configure script for the target and the host. >> >> Note: configure scripts generated with autoconf < 2.65 will source >> the /dev/null and print this line: >> "configure: loading site script /dev/null" >> >> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 >> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> > > I am wondering if this change should go in master (for 2014.08) or in > the next branch (for 2014.11). That close to the release, doing a > change in the core infrastructure seems a bit invasive to me. What if > it breaks the build of other packages? Seems unlikely, I admit, but > still. What do others think? I think this patch can go to next since the issue is already fixed in master but just for host-localedef. Actually, it seems that only host-localedef was affected by this issue. Best regards, Romain > Thanks! > > Thomas >
Hi Thomas, Romain, On Sun, Aug 24, 2014 at 6:39 PM, Romain Naour <romain.naour@openwide.fr> wrote: > Hi Thomas, > > Le 24/08/2014 18:14, Thomas Petazzoni a écrit : >> Dear Romain Naour, >> >> On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote: >>> On fedora 20 64bits host, the file /usr/share/config.site contains >>> a fix for installing libraries into /lib/lib64 on 64bits systems >>> that redefine libdir in the generated Makefile >>> >>> For safety and avoid the bug #7262 [1], disable loading this file >>> when running the configure script for the target and the host. >>> >>> Note: configure scripts generated with autoconf < 2.65 will source >>> the /dev/null and print this line: >>> "configure: loading site script /dev/null" >>> >>> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 >>> >>> Signed-off-by: Romain Naour <romain.naour@openwide.fr> >> >> I am wondering if this change should go in master (for 2014.08) or in >> the next branch (for 2014.11). That close to the release, doing a >> change in the core infrastructure seems a bit invasive to me. What if >> it breaks the build of other packages? Seems unlikely, I admit, but >> still. What do others think? > > I think this patch can go to next since the issue is already fixed in master but > just for host-localedef. > > Actually, it seems that only host-localedef was affected by this issue. > I was going to judge 'master', but then I saw Romain's reply. The reported bug is indeed already fixed, and no other problems were reported so far, so I agree now with applying these patches to -next. Best regards, Thomas
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes: > On fedora 20 64bits host, the file /usr/share/config.site contains > a fix for installing libraries into /lib/lib64 on 64bits systems > that redefine libdir in the generated Makefile > For safety and avoid the bug #7262 [1], disable loading this file > when running the configure script for the target and the host. > Note: configure scripts generated with autoconf < 2.65 will source > the /dev/null and print this line: > "configure: loading site script /dev/null" > [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Committed, thanks.
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index bcc648d..a424a1c 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -126,6 +126,7 @@ define $(2)_CONFIGURE_CMDS $$(TARGET_CONFIGURE_OPTS) \ $$(TARGET_CONFIGURE_ARGS) \ $$($$(PKG)_CONF_ENV) \ + CONFIG_SITE=/dev/null \ ./configure \ --target=$$(GNU_TARGET_NAME) \ --host=$$(GNU_TARGET_NAME) \ @@ -159,6 +160,7 @@ define $(2)_CONFIGURE_CMDS CFLAGS="$$(HOST_CFLAGS)" \ LDFLAGS="$$(HOST_LDFLAGS)" \ $$($$(PKG)_CONF_ENV) \ + CONFIG_SITE=/dev/null \ ./configure \ --prefix="$$(HOST_DIR)/usr" \ --sysconfdir="$$(HOST_DIR)/etc" \
On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host. Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line: "configure: loading site script /dev/null" [1]: https://bugs.busybox.net/show_bug.cgi?id=7262 Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- v2: Use /dev/null for CONFIG_SITE to avoid sourcing a file nammed "no" (ThomasDS and Mike Zick) Add a note about autoconf version Add reference to the bug #7262 --- package/pkg-autotools.mk | 2 ++ 1 file changed, 2 insertions(+)