diff mbox

[U-Boot,2/2] buildman: run genboardscfg.py all the time

Message ID 1408685621-12867-3-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Aug. 22, 2014, 5:33 a.m. UTC
This commit makes sure boards.cfg is up to date before starting
the build tests.  tools/genboardscfg.py exits immediately printing
"boards.cfg is up to date. Nothing to do." when boards.cfg is
already new.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 tools/buildman/control.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

Simon Glass Aug. 23, 2014, 1:49 a.m. UTC | #1
On 21 August 2014 23:33, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> This commit makes sure boards.cfg is up to date before starting
> the build tests.  tools/genboardscfg.py exits immediately printing
> "boards.cfg is up to date. Nothing to do." when boards.cfg is
> already new.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini Aug. 29, 2014, 2:40 p.m. UTC | #2
On Fri, Aug 22, 2014 at 02:33:41PM +0900, Masahiro Yamada wrote:

> This commit makes sure boards.cfg is up to date before starting
> the build tests.  tools/genboardscfg.py exits immediately printing
> "boards.cfg is up to date. Nothing to do." when boards.cfg is
> already new.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index d98e50a..68ea961 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -120,12 +120,10 @@  def DoBuildman(options, args):
 
     # Work out what subset of the boards we are building
     board_file = os.path.join(options.git, 'boards.cfg')
-    if not os.path.exists(board_file):
-        print 'Could not find %s' % board_file
-        status = subprocess.call([os.path.join(options.git,
-                                               'tools/genboardscfg.py')])
-        if status != 0:
-            sys.exit("Failed to generate boards.cfg")
+    status = subprocess.call([os.path.join(options.git,
+                                           'tools/genboardscfg.py')])
+    if status != 0:
+        sys.exit("Failed to generate boards.cfg")
 
     boards = board.Boards()
     boards.ReadBoards(os.path.join(options.git, 'boards.cfg'))