Patchwork [12/20] pci: remove some unnecessary comment in pci.h

login
register
mail settings
Submitter Isaku Yamahata
Date Nov. 12, 2009, 5:58 a.m.
Message ID <1258005528-25383-13-git-send-email-yamahata@valinux.co.jp>
Download mbox | patch
Permalink /patch/38207/
State New
Headers show

Comments

Isaku Yamahata - Nov. 12, 2009, 5:58 a.m.
This patch removes some comment which should go into commit log
in pci.h.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/pci.h |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)
Michael S. Tsirkin - Nov. 12, 2009, 10:33 a.m.
On Thu, Nov 12, 2009 at 02:58:40PM +0900, Isaku Yamahata wrote:
> This patch removes some comment which should go into commit log
> in pci.h.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.h |   11 ++---------
>  1 files changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index cd04189..988d2c0 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -382,17 +382,10 @@ typedef struct {
>      PCIConfigWriteFunc *config_write;
>  
>      /* pci config header type */
> -    uint8_t header_type;        /* this is necessary for initialization
> -                                 * code to know its header type before
> -                                 * device specific code can initialize
> -                                 * configuration space.
> -                                 */
> +    uint8_t header_type;
>  
>      /* pcie stuff */
> -    int is_express;   /* is this device pci express?
> -                       * initialization code needs to know this before
> -                       * each specific device initialization.
> -                       */
> +    int is_express;   /* is this device pci express? */
>  } PCIDeviceInfo;
>  
>  void pci_qdev_register(PCIDeviceInfo *info);
> -- 
> 1.6.0.2

Patch

diff --git a/hw/pci.h b/hw/pci.h
index cd04189..988d2c0 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -382,17 +382,10 @@  typedef struct {
     PCIConfigWriteFunc *config_write;
 
     /* pci config header type */
-    uint8_t header_type;        /* this is necessary for initialization
-                                 * code to know its header type before
-                                 * device specific code can initialize
-                                 * configuration space.
-                                 */
+    uint8_t header_type;
 
     /* pcie stuff */
-    int is_express;   /* is this device pci express?
-                       * initialization code needs to know this before
-                       * each specific device initialization.
-                       */
+    int is_express;   /* is this device pci express? */
 } PCIDeviceInfo;
 
 void pci_qdev_register(PCIDeviceInfo *info);