diff mbox

[RFC,8/9] block: Implement stub bdrv_em_co_aiocb_info.cancel_async

Message ID 1408622216-9578-9-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Aug. 21, 2014, 11:56 a.m. UTC 
Nothing to do here.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stefan Hajnoczi Aug. 21, 2014, 5:01 p.m. UTC | #1 
On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote:
> diff --git a/block.c b/block.c
> index 1cc8926..1860e4b 100644
> --- a/block.c
> +++ b/block.c
> @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb)
>      }
>  }
>  
> +static void bdrv_aio_co_cancel_em_async(BlockDriverAIOCB *blockacb)
> +{
> +}

Please include a comment to explain why this function body is empty:

/* Do nothing, let caller wait for the request to complete */
Fam Zheng Aug. 22, 2014, 4:28 a.m. UTC | #2 
On Thu, 08/21 18:01, Stefan Hajnoczi wrote:
> On Thu, Aug 21, 2014 at 07:56:55PM +0800, Fam Zheng wrote:
> > diff --git a/block.c b/block.c
> > index 1cc8926..1860e4b 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -4750,9 +4750,14 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb)
> >      }
> >  }
> >  
> > +static void bdrv_aio_co_cancel_em_async(BlockDriverAIOCB *blockacb)
> > +{
> > +}
> 
> Please include a comment to explain why this function body is empty:
> 
> /* Do nothing, let caller wait for the request to complete */

OK.

Fam
diff mbox

Patch

diff --git a/block.c b/block.c
index 1cc8926..1860e4b 100644
--- a/block.c
+++ b/block.c
@@ -4750,9 +4750,14 @@  static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb)
     }
 }
 
+static void bdrv_aio_co_cancel_em_async(BlockDriverAIOCB *blockacb)
+{
+}
+
 static const AIOCBInfo bdrv_em_co_aiocb_info = {
     .aiocb_size         = sizeof(BlockDriverAIOCBCoroutine),
     .cancel             = bdrv_aio_co_cancel_em,
+    .cancel_async       = bdrv_aio_co_cancel_em_async,
 };
 
 static void bdrv_co_em_bh(void *opaque)