| Submitter | roel kluin |
|---|---|
| Date | Nov. 11, 2009, 10:33 p.m. |
| Message ID | <4AFB3B9D.1080606@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/38188/ |
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Comments
Roel Kluin wrote:
> Return a negative error value
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c index 63e1905..4d1a41b 100644 --- a/net/netfilter/xt_osf.c +++ b/net/netfilter/xt_osf.c @@ -118,7 +118,7 @@ static int xt_osf_remove_callback(struct sock *ctnl, struct sk_buff *skb, { struct xt_osf_user_finger *f; struct xt_osf_finger *sf; - int err = ENOENT; + int err = -ENOENT; if (!osf_attrs[OSF_ATTR_FINGER]) return -EINVAL;
Return a negative error value Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- net/netfilter/xt_osf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) It seems strange that an error return can be positive or negative, is this maybe required? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html