From patchwork Thu Aug 21 04:04:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Almeida X-Patchwork-Id: 381856 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7DF88140082 for ; Thu, 21 Aug 2014 14:02:00 +1000 (EST) Received: from localhost ([127.0.0.1] helo=ganesha.gnumonks.org) by ganesha.gnumonks.org with esmtp (Exim 4.72) (envelope-from ) id 1XKJYx-00017Y-N8; Thu, 21 Aug 2014 06:01:23 +0200 Received: from mail-vc0-x230.google.com ([2607:f8b0:400c:c03::230]) by ganesha.gnumonks.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from ) id 1XKJY2-00017B-0x for baseband-devel@lists.osmocom.org; Thu, 21 Aug 2014 06:00:30 +0200 Received: by mail-vc0-f176.google.com with SMTP id id10so10054825vcb.21 for ; Wed, 20 Aug 2014 21:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=/ARPXOq7TqA2xrOXJ3QdDbaTllu3HsspALQ4oBXwZP8=; b=DlwVuUVLeQfB5iEpcyRuUs0zKS1xN2sC63JAMAEigR9+Lvbx22Mj/QZrSw9JLn4+uK lAa82hhmS6grjZ+5IsyTJkjRXQINUVvrBRMmpK9gIqGSW674SUdXp7yNQlvTeERoNtgm 2MpaZ568vGlMgG0BBQaWvyrYIBC9SuJv9uD4oGfbsQwJZUzZFpbT0WSuT2JUmN3on6ol 4m66luVhBOnmuCdytceXj+QmaOjk1DNVMtPFV8x4LFnxKf5sRm9MC3N0IeYo9fmvgy8W DqhTYAjhBX/CxHVEhCMwdj2QgG2PmoNexic+wuIv5dH7lbyPlcMFEeIaBxdjU6A3/nGA Xz3w== X-Received: by 10.52.27.16 with SMTP id p16mr278767vdg.14.1408593621579; Wed, 20 Aug 2014 21:00:21 -0700 (PDT) Received: from [192.168.42.121] ([152.239.9.245]) by mx.google.com with ESMTPSA id em9sm74316354vdc.8.2014.08.20.21.00.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Aug 2014 21:00:20 -0700 (PDT) Message-ID: <53F56FD6.9070404@gmail.com> Date: Thu, 21 Aug 2014 01:04:38 -0300 From: Igor Almeida User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Holger Hans Peter Freyther , Milinko Isakovic Subject: Re: Mobile testing branch References: <20140730102846.GV5744@xiaoyu.lan> In-Reply-To: <20140730102846.GV5744@xiaoyu.lan> X-Spam-Score: -0.1 (/) Cc: Sylvain Munaut <246tnt@gmail.com>, tom mc loughlin , baseband-devel X-BeenThere: baseband-devel@lists.osmocom.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development discussion about Osmocom BaseBand List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: baseband-devel-bounces@lists.osmocom.org Errors-To: baseband-devel-bounces@lists.osmocom.org Hi, On 07/30/2014 07:28 AM, Holger Hans Peter Freyther wrote: > On Wed, Jul 30, 2014 at 10:54:39AM +0200, Milinko Isakovic wrote: >> Hi I have same problem. > > Hi, > >> msgb(0x1638020): Not enough headroom msgb_push (4271669080 < 7) >> backtrace() returned 10 addresses >> /usr/local/lib/libosmocore.so.4(osmo_panic+0xb9) [0x7f2b4ea57929] >> /usr/local/lib/libosmogsm.so.5(lapdm_phsap_up+0x16f) [0x7f2b4e62378f] >> ./mobile() [0x43981c] >> ./mobile() [0x439fce] >> /usr/local/lib/libosmocore.so.4(osmo_wqueue_bfd_cb+0x93) [0x7f2b4ea550d3] >> /usr/local/lib/libosmocore.so.4(osmo_select_main+0x1b1) [0x7f2b4ea54171] >> ./mobile() [0x404be7] >> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfd) [0x7f2b4e099eed] >> ./mobile() [0x404d59] > > we are still waiting for a patch. The LAPDm code is using l2h/l3h but > in rx_l1_rach_conf it is not initialized at all. > > Patches welcome. > The attached patch works for me. Anything I've missed? > holger > From ef2b86acdfc78c3fd2725daea1d70a4904348c48 Mon Sep 17 00:00:00 2001 From: Igor Almeida Date: Thu, 21 Aug 2014 00:30:22 -0300 Subject: [PATCH] layer23: initialize l2h/l3h pointers Signed-off-by: Igor Almeida --- src/host/layer23/src/common/l1ctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 91bab89..c75872e 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -148,6 +148,7 @@ static int rx_l1_rach_conf(struct osmocom_ms *ms, struct msgb *msg) } dl = (struct l1ctl_info_dl *) msg->l1h; + msg->l2h = msg->l3h = dl->payload; osmo_prim_init(&pp.oph, SAP_GSM_PH, PRIM_PH_RACH, PRIM_OP_CONFIRM, msg); -- 2.0.1