Message ID | 20140820175440.GA4556@himangi-Dell |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Himangi Saraogi <himangi774@gmail.com> Date: Wed, 20 Aug 2014 23:24:40 +0530 > The functions time_before, time_before_eq, time_after, and time_after_eq > are more robust for comparing jiffies against other values. > > A simplified version of the Coccinelle semantic patch making this change > is as follows: > > @change@ > expression E1,E2,E3; > @@ > - jiffies - E1 >= (E2*E3) > + time_after_eq(jiffies, E1+E2*E3) > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index ae011b4..25733d5 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c @@ -127,6 +127,7 @@ Version 0.0.6 2.1.110 07-aug-98 Eduardo Marcelo Serrat #include <linux/stat.h> #include <linux/init.h> #include <linux/poll.h> +#include <linux/jiffies.h> #include <net/net_namespace.h> #include <net/neighbour.h> #include <net/dst.h> @@ -598,7 +599,7 @@ int dn_destroy_timer(struct sock *sk) if (sk->sk_socket) return 0; - if ((jiffies - scp->stamp) >= (HZ * decnet_time_wait)) { + if (time_after_eq(jiffies, scp->stamp + HZ * decnet_time_wait)) { dn_unhash_sock(sk); sock_put(sk); return 1;