| Message ID | 1408473276-10847-1-git-send-email-atull@opensource.altera.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Aug 19, 2014 at 01:34:35PM -0500, atull@opensource.altera.com wrote: > From: Alan Tull <atull@opensource.altera.com> > > Add "speed-mode" Device Tree property to select between > standard and fast i2c mode. Previously, driver was hardwired > as fast mode. Default to fast mode if property is not > present. NACK. This should be deduced from the clock-frequency setting... > > Signed-off-by: Alan Tull <atull@opensource.altera.com> > --- > .../devicetree/bindings/i2c/i2c-designware.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > index 5199b0c..0e4cd21 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > @@ -9,6 +9,8 @@ Required properties : > Recommended properties : > > - clock-frequency : desired I2C bus clock frequency in Hz. ... which is described here, but surprisingly not supported in the driver yet :( Check i2c-riic for an example. > + - speed-mode : 0 = standard (0 - 100Kb/s) > + : 1 = fast (<= 400Kb/s) <== default > > Optional properties : > - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. > @@ -29,6 +31,7 @@ Example : > reg = <0xf0000 0x1000>; > interrupts = <11>; > clock-frequency = <400000>; > + speed-mode = <0>; > }; > > i2c@1120000 { > -- > 1.7.9.5 >
On Tue, 19 Aug 2014, Wolfram Sang wrote: > On Tue, Aug 19, 2014 at 01:34:35PM -0500, atull@opensource.altera.com wrote: > > From: Alan Tull <atull@opensource.altera.com> > > > > Add "speed-mode" Device Tree property to select between > > standard and fast i2c mode. Previously, driver was hardwired > > as fast mode. Default to fast mode if property is not > > present. > > NACK. This should be deduced from the clock-frequency setting... I just sent out a new patch that looks at the clock-frequency setting. Alan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 19, 2014 at 07:34:35PM +0100, atull@opensource.altera.com wrote: > From: Alan Tull <atull@opensource.altera.com> > > Add "speed-mode" Device Tree property to select between > standard and fast i2c mode. Previously, driver was hardwired > as fast mode. Default to fast mode if property is not > present. > > Signed-off-by: Alan Tull <atull@opensource.altera.com> > --- > .../devicetree/bindings/i2c/i2c-designware.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > index 5199b0c..0e4cd21 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > @@ -9,6 +9,8 @@ Required properties : > Recommended properties : > > - clock-frequency : desired I2C bus clock frequency in Hz. > + - speed-mode : 0 = standard (0 - 100Kb/s) > + : 1 = fast (<= 400Kb/s) <== default This is a bit opaque. Is this a limit on the max bit-rate the device should operate at? Why not just have an optional boolean property to limit to standard speed? Thanks, Mark. > > Optional properties : > - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. > @@ -29,6 +31,7 @@ Example : > reg = <0xf0000 0x1000>; > interrupts = <11>; > clock-frequency = <400000>; > + speed-mode = <0>; > }; > > i2c@1120000 { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 20, 2014 at 10:34:59AM +0100, Mark Rutland wrote: > On Tue, Aug 19, 2014 at 07:34:35PM +0100, atull@opensource.altera.com wrote: > > From: Alan Tull <atull@opensource.altera.com> > > > > Add "speed-mode" Device Tree property to select between > > standard and fast i2c mode. Previously, driver was hardwired > > as fast mode. Default to fast mode if property is not > > present. > > > > Signed-off-by: Alan Tull <atull@opensource.altera.com> > > --- > > .../devicetree/bindings/i2c/i2c-designware.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > > index 5199b0c..0e4cd21 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt > > @@ -9,6 +9,8 @@ Required properties : > > Recommended properties : > > > > - clock-frequency : desired I2C bus clock frequency in Hz. > > + - speed-mode : 0 = standard (0 - 100Kb/s) > > + : 1 = fast (<= 400Kb/s) <== default > > This is a bit opaque. > > Is this a limit on the max bit-rate the device should operate at? > > Why not just have an optional boolean property to limit to standard > speed? I see there's a new patch doing this based on clock-frequency, so feel free to ignore this. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt index 5199b0c..0e4cd21 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt @@ -9,6 +9,8 @@ Required properties : Recommended properties : - clock-frequency : desired I2C bus clock frequency in Hz. + - speed-mode : 0 = standard (0 - 100Kb/s) + : 1 = fast (<= 400Kb/s) <== default Optional properties : - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. @@ -29,6 +31,7 @@ Example : reg = <0xf0000 0x1000>; interrupts = <11>; clock-frequency = <400000>; + speed-mode = <0>; }; i2c@1120000 {