From patchwork Wed Nov 11 04:44:29 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: vimal singh X-Patchwork-Id: 38125 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A0BA0B708B for ; Wed, 11 Nov 2009 15:46:45 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N854j-0005s5-2L; Wed, 11 Nov 2009 04:44:57 +0000 Received: from mail-bw0-f212.google.com ([209.85.218.212]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N854c-0005c0-56 for linux-mtd@lists.infradead.org; Wed, 11 Nov 2009 04:44:54 +0000 Received: by bwz4 with SMTP id 4so704733bwz.2 for ; Tue, 10 Nov 2009 20:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=JtvgRCOCMXMIVkmnmpDOhg2o/cti8kabBmuVxznSM64=; b=vzA9wCX8aR0dyB5fH4wXq4gs4B2du0XYwIrsp0onhDaHm4jhGSMba3rBfg/nDfkdvq 7tu1Vc7LAdatozl3lfdC/ZdBnuobUTJSeWeZTKGjJfmDTKdND3AQNMjlgxZ1nlIo3YjC VkKy45ixVai/41TkCtvSljR+hoSAI6GtOMABY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=PUEPUhASluEQhbcN+8aUdF82v05vJWYs6oBMKAeU1wE4DPPeWvuZSV8Ab3OzNPv6w9 VvSdSygZkPIjbh04EHDmX/u41qoAgYs8PYJCg5rXKFbtITx/vu/npW/n1HRuyowKCcK6 fe1MsbRu4jhoE52ryqQi5CKJ0ul9TyrKSXHaA= MIME-Version: 1.0 Received: by 10.204.32.213 with SMTP id e21mr994941bkd.34.1257914689112; Tue, 10 Nov 2009 20:44:49 -0800 (PST) In-Reply-To: <1257863063.21596.765.camel@localhost> References: <1257236323.21596.56.camel@localhost> <1257237728.21596.65.camel@localhost> <1257863063.21596.765.camel@localhost> From: Vimal Singh Date: Wed, 11 Nov 2009 10:14:29 +0530 Message-ID: Subject: Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c' To: dedekind1@gmail.com X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091110_234450_418819_C16F1407 X-CRM114-Status: GOOD ( 19.64 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ Cc: linux-omap@vger.kernel.org, Linux MTD X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Tue, Nov 10, 2009 at 7:54 PM, Artem Bityutskiy wrote: > On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote: >> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >> >> index 090ab87..92573d5 100644 >> >> --- a/drivers/mtd/nand/omap2.c >> >> +++ b/drivers/mtd/nand/omap2.c >> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct >> >> mtd_info *mtd, u_char >> > >> > :-) It is the same again. >> > >> > Try to send the e-mail to yourself, then save it and apply with git-am. >> > If it works, send to the mailing list. >> >> Below patch applies. Sorry for noise... :( >> >> Thanks, >> vimal >> >> >> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001 >> From: Vimal Singh >> Date: Fri, 30 Oct 2009 11:31:34 +0530 >> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' >> >> Fixing below warning in compilation: >> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': >> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of >> 'omap_nand_dma_transfer' discards qualifiers from pointer target type >> >> Signed-off-by: Vimal Singh >> --- >>  drivers/mtd/nand/omap2.c |    6 ++++-- >>  1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >> index 090ab87..92573d5 100644 >> --- a/drivers/mtd/nand/omap2.c >> +++ b/drivers/mtd/nand/omap2.c >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct >>  static void omap_write_buf_dma_pref(struct mtd_info *mtd, >>                                       const u_char *buf, int len) >>  { >> +     u_char *p = (u_char *)buf; >> + >>       if (len <= mtd->oobsize) >> -             omap_write_buf_pref(mtd, buf, len); >> +             omap_write_buf_pref(mtd, p, len); >>       else >>               /* start transfer in DMA mode */ >> -             omap_nand_dma_transfer(mtd, buf, len, 0x1); >> +             omap_nand_dma_transfer(mtd, p, len, 0x1); >>  } >> >>  /** > > BTW, this patch is still corrupted for me. And it is strange that I do > not see it in the archives, so I cannot check is this my setup which is > guilty, or it is you sending the patches incorrectly: > > http://lists.infradead.org/pipermail/linux-mtd/2009-November/027918.html Here is the patch once again: Fixing below warning in compilation: drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of 'omap_nand_dma_transfer' discards qualifiers from pointer target type Signed-off-by: Vimal Singh --- drivers/mtd/nand/omap2.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 090ab87..92573d5 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct static void omap_write_buf_dma_pref(struct mtd_info *mtd, const u_char *buf, int len) { + u_char *p = (u_char *)buf; + if (len <= mtd->oobsize) - omap_write_buf_pref(mtd, buf, len); + omap_write_buf_pref(mtd, p, len); else /* start transfer in DMA mode */ - omap_nand_dma_transfer(mtd, buf, len, 0x1); + omap_nand_dma_transfer(mtd, p, len, 0x1); } /**