Patchwork Re: [PATCH 0/2] Build fixes

login
register
mail settings
Submitter Paul Brook
Date Nov. 11, 2009, 3:07 a.m.
Message ID <200911110307.27227.paul@codesourcery.com>
Download mbox | patch
Permalink /patch/38124/
State New
Headers show

Comments

Paul Brook - Nov. 11, 2009, 3:07 a.m.
On Thursday 05 November 2009, Juan Quintela wrote:
> Daniel Jacobowitz <dan@codesourcery.com> wrote:
> > On Thu, Nov 05, 2009 at 05:17:46PM +0100, Juan Quintela wrote:
> >> How are you compiling?
> >> It works for me compiling in-tree with make -j3 (only 2 cores)
> >
> > I can reliably reproduce it by building all my QEMU configs at once.
> > I think that's a four-core or eight-core machine, -j4 in each build,
> > six separate qemu build trees.  I've reproduced it in a single build
> > tree a couple of times, but not reliably.
> 
> I have no way to reproduce reliablely :(

rm -f qemu-tool.[od] config-host.h
make qemu-tool.o

Reproduces reliably.
The following patch should expose any similar failures:

$*.h
        @cmp $@ $*.h >/dev/null 2>&1 || cp $@ $*.h


Paul
Juan Quintela - Nov. 11, 2009, 10:28 a.m.
Paul Brook <paul@codesourcery.com> wrote:
> On Thursday 05 November 2009, Juan Quintela wrote:
>> Daniel Jacobowitz <dan@codesourcery.com> wrote:
>> > On Thu, Nov 05, 2009 at 05:17:46PM +0100, Juan Quintela wrote:
>> >> How are you compiling?
>> >> It works for me compiling in-tree with make -j3 (only 2 cores)
>> >
>> > I can reliably reproduce it by building all my QEMU configs at once.
>> > I think that's a four-core or eight-core machine, -j4 in each build,
>> > six separate qemu build trees.  I've reproduced it in a single build
>> > tree a couple of times, but not reliably.
>> 
>> I have no way to reproduce reliablely :(
>
> rm -f qemu-tool.[od] config-host.h
> make qemu-tool.o
>
> Reproduces reliably.
> The following patch should expose any similar failures:

My last series of build fixes serie fix this one also.
They are already on staging.

Thanks for the test case, Juan.

> --- a/rules.mak
> +++ b/rules.mak
> @@ -44,5 +44,6 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc 
> /dev/
>         @test -f $@ || cp $< $@
>
>  %.h-timestamp: %.mak
> +       sleep 60
>         $(call quiet-command, $(SRC_PATH)/create_config < $< > $@, "  GEN   
> $*.h
>         @cmp $@ $*.h >/dev/null 2>&1 || cp $@ $*.h
>
>
> Paul

Patch

--- a/rules.mak
+++ b/rules.mak
@@ -44,5 +44,6 @@  cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc 
/dev/
        @test -f $@ || cp $< $@

 %.h-timestamp: %.mak
+       sleep 60
        $(call quiet-command, $(SRC_PATH)/create_config < $< > $@, "  GEN