From patchwork Tue Nov 10 08:55:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 38046 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E105DB7088 for ; Tue, 10 Nov 2009 19:55:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbZKJIzv (ORCPT ); Tue, 10 Nov 2009 03:55:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752171AbZKJIzv (ORCPT ); Tue, 10 Nov 2009 03:55:51 -0500 Received: from mail-bw0-f227.google.com ([209.85.218.227]:60509 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbZKJIzu (ORCPT ); Tue, 10 Nov 2009 03:55:50 -0500 Received: by bwz27 with SMTP id 27so4301119bwz.21 for ; Tue, 10 Nov 2009 00:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:x-x-sender:to:cc :subject:message-id:user-agent:mime-version:content-type; bh=kEWIk4CyebgJX1vs/6C9PMe6Pieoyn1Z1ZFzbnRh+NQ=; b=xkwxbTIhGKkLIX4HYP3TBf/tPCSSQesvPX6tsjwXWBqafayImekcEmCdjNSLEV8I0/ JYNXXToBE0jgNmWFb3AM17ih0F08gU1b/5AqU05PlTMlp0nQFYN+0v2s+8v0t4J6ZEYE t+d8YXS5Wqe8uQ26X0eDdC/2Tt+jKuvY/DsDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:cc:subject:message-id:user-agent :mime-version:content-type; b=bT0e25nixlTMVNnp4/Eg4lIEfKK6SY/o29mh3Jx12RmSiBMjMHIbU7wWWWQXLJRBHV hPOAtOduW3JFAZUngQGkdY4f39WkOVF9vEUCeVz84+uijX/BjXALPWLnH8fLGeKHuYps Cjj1cIvuy+0S2t+KUn9GpmpFaeW3ykOEkhTBQ= Received: by 10.204.24.65 with SMTP id u1mr9754829bkb.176.1257843354892; Tue, 10 Nov 2009 00:55:54 -0800 (PST) Received: from bicker.local ([41.222.20.196]) by mx.google.com with ESMTPS id 15sm136672bwz.8.2009.11.10.00.55.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 10 Nov 2009 00:55:53 -0800 (PST) Date: Tue, 10 Nov 2009 10:55:43 +0200 (SAST) From: Dan Carpenter X-X-Sender: dcarpenter@bicker To: linux-ide@vger.kernel.org cc: davem@davemloft.net Subject: [patch] move dereference after null check Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org I moved the ops->inherits dereference below the null check. I moved the other assignment as well so that they would be together. Found by smatch static checker. regards, dan carpenter Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- orig/drivers/ata/libata-core.c 2009-11-08 19:40:18.000000000 +0200 +++ devel/drivers/ata/libata-core.c 2009-11-08 19:42:06.000000000 +0200 @@ -5938,13 +5938,14 @@ { static DEFINE_SPINLOCK(lock); const struct ata_port_operations *cur; - void **begin = (void **)ops; - void **end = (void **)&ops->inherits; - void **pp; + void **begin, **end, **pp; if (!ops || !ops->inherits) return; + begin = (void **)ops; + end = (void **)&ops->inherits; + spin_lock(&lock); for (cur = ops->inherits; cur; cur = cur->inherits) {