| Message ID | 1408097555-28126-13-git-send-email-aik@ozlabs.ru |
|---|---|
| State | New |
| Headers | show |
On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: > This enables DDW RTAS-related ioctls in VFIO. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> This should probably just be folded into the previous patch. It's broken without this change.
On 08/26/2014 05:20 PM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: >> This enables DDW RTAS-related ioctls in VFIO. >> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> > > This should probably just be folded into the previous patch. It's > broken without this change. It won't work but it is not broken - guest will fail to create DDW and continue using the default windows. And since the series needs attention of 2 maintainers (A. Williamson and A. Graf), it is better to draw bold line between areas :)
On Tue, Aug 26, 2014 at 06:20:51PM +1000, Alexey Kardashevskiy wrote: > On 08/26/2014 05:20 PM, David Gibson wrote: > > On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: > >> This enables DDW RTAS-related ioctls in VFIO. > >> > >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> > > > > This should probably just be folded into the previous patch. It's > > broken without this change. > > It won't work but it is not broken - guest will fail to create DDW and > continue using the default windows. > > And since the series needs attention of 2 maintainers (A. Williamson and A. > Graf), it is better to draw bold line between areas :) Ah, ok, that makes sense then.
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index ba08adb..5b95cfa 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -4453,6 +4453,10 @@ int vfio_container_ioctl(AddressSpace *as, int32_t groupid, switch (req) { case VFIO_CHECK_EXTENSION: case VFIO_IOMMU_SPAPR_TCE_GET_INFO: + case VFIO_IOMMU_SPAPR_TCE_QUERY: + case VFIO_IOMMU_SPAPR_TCE_CREATE: + case VFIO_IOMMU_SPAPR_TCE_REMOVE: + case VFIO_IOMMU_SPAPR_TCE_RESET: break; default: /* Return an error on unknown requests */
This enables DDW RTAS-related ioctls in VFIO. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- hw/misc/vfio.c | 4 ++++ 1 file changed, 4 insertions(+)