diff mbox

[PULL,07/12] numa: show hex number in error message for consistency and prefix them with 0x

Message ID 1408032488-11096-8-git-send-email-mst@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin Aug. 14, 2014, 4:09 p.m. UTC 
From: Hu Tao <hutao@cn.fujitsu.com>

The error messages before and after patch are:

before:
qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal RAM size (20000000)

after:
qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal RAM size (0x20000000)

Cc: qemu-stable@nongnu.org
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 numa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eduardo Habkost Aug. 14, 2014, 6:57 p.m. UTC | #1 
On Thu, Aug 14, 2014 at 06:09:03PM +0200, Michael S. Tsirkin wrote:
> From: Hu Tao <hutao@cn.fujitsu.com>
> 
> The error messages before and after patch are:
> 
> before:
> qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal RAM size (20000000)
> 
> after:
> qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal RAM size (0x20000000)

Why hex? Why not change both to decimal?
Michael S. Tsirkin Aug. 14, 2014, 7:22 p.m. UTC | #2 
On Thu, Aug 14, 2014 at 03:57:53PM -0300, Eduardo Habkost wrote:
> On Thu, Aug 14, 2014 at 06:09:03PM +0200, Michael S. Tsirkin wrote:
> > From: Hu Tao <hutao@cn.fujitsu.com>
> > 
> > The error messages before and after patch are:
> > 
> > before:
> > qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal RAM size (20000000)
> > 
> > after:
> > qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal RAM size (0x20000000)
> 
> Why hex? Why not change both to decimal?

Reasonable number is usually very large and a power of 2,
hex is easier to read.

> -- 
> Eduardo
diff mbox

Patch

diff --git a/numa.c b/numa.c
index 7bf7834..c78cec9 100644
--- a/numa.c
+++ b/numa.c
@@ -210,8 +210,8 @@  void set_numa_nodes(void)
             numa_total += numa_info[i].node_mem;
         }
         if (numa_total != ram_size) {
-            error_report("total memory for NUMA nodes (%" PRIu64 ")"
-                         " should equal RAM size (" RAM_ADDR_FMT ")",
+            error_report("total memory for NUMA nodes (0x%" PRIx64 ")"
+                         " should equal RAM size (0x" RAM_ADDR_FMT ")",
                          numa_total, ram_size);
             exit(1);
         }