diff mbox

[U-Boot] Makefile: Use Kbuild style for system_map.o generation step

Message ID 1408009255-6444-1-git-send-email-vvv444@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Vasili Galka Aug. 14, 2014, 9:40 a.m. UTC 
The command generating the "common/system_map.o" file was always shown
during the build making the output messy. Now it is called using the
Kbuild "cmd" macro, so that the full command is shown only when
building in verbose mode.

Signed-off-by: Vasili Galka <vvv444@gmail.com>
---
 Makefile |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

Comments

Tom Rini Aug. 23, 2014, 12:42 p.m. UTC | #1 
On Thu, Aug 14, 2014 at 12:40:55PM +0300, Vasili Galka wrote:

> The command generating the "common/system_map.o" file was always shown
> during the build making the output messy. Now it is called using the
> Kbuild "cmd" macro, so that the full command is shown only when
> building in verbose mode.
> 
> Signed-off-by: Vasili Galka <vvv444@gmail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index b5d5e01..7c0352c 100644
--- a/Makefile
+++ b/Makefile
@@ -1006,13 +1006,17 @@  quiet_cmd_u-boot__ ?= LD      $@
       --start-group $(u-boot-main) --end-group                 \
       $(PLATFORM_LIBS) -Map u-boot.map
 
-u-boot:	$(u-boot-init) $(u-boot-main) u-boot.lds
-	$(call if_changed,u-boot__)
-ifeq ($(CONFIG_KALLSYMS),y)
+quiet_cmd_smap = GEN     common/system_map.o
+cmd_smap = \
 	smap=`$(call SYSTEM_MAP,u-boot) | \
 		awk '$$2 ~ /[tTwW]/ {printf $$1 $$3 "\\\\000"}'` ; \
 	$(CC) $(c_flags) -DSYSTEM_MAP="\"$${smap}\"" \
 		-c $(srctree)/common/system_map.c -o common/system_map.o
+
+u-boot:	$(u-boot-init) $(u-boot-main) u-boot.lds
+	$(call if_changed,u-boot__)
+ifeq ($(CONFIG_KALLSYMS),y)
+	$(call cmd,smap)
 	$(call cmd,u-boot__) common/system_map.o
 endif