| Submitter | Steven A. Falco |
|---|---|
| Date | Oct. 10, 2008, 2:04 p.m. |
| Message ID | <48EF60F1.1010001@harris.com> |
| Download | mbox | patch |
| Permalink | /patch/3797/ |
| State | Accepted |
| Commit | e3274e915061a65717454106301d4a5ea8f71783 |
| Headers | show |
Comments
On Friday 10 October 2008, Steven A. Falco wrote: > gpiolib can export GPIOs to userspace via sysfs. This patch modifies > the gpio_value_show() so that any non-zero value is explicitly printed > as "1", rather than whatever numerical value the lower-level driver returns. > > Signed-off-by: Steve Falco <sfalco at harris.com> I just forwarded this to Andrew (cc LKML) with my signoff ... sorry I forgot to add you to the CC. :( > --- > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 8d29405..36bf72b 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -237,7 +237,7 @@ static ssize_t gpio_value_show(struct device *dev, > if (!test_bit(FLAG_EXPORT, &desc->flags)) > status = -EIO; > else > - status = sprintf(buf, "%d\n", gpio_get_value_cansleep(gpio)); > + status = sprintf(buf, "%d\n", !!gpio_get_value_cansleep(gpio)); > > mutex_unlock(&sysfs_lock); > return status; > >
Patch
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 8d29405..36bf72b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -237,7 +237,7 @@ static ssize_t gpio_value_show(struct device *dev, if (!test_bit(FLAG_EXPORT, &desc->flags)) status = -EIO; else - status = sprintf(buf, "%d\n", gpio_get_value_cansleep(gpio)); + status = sprintf(buf, "%d\n", !!gpio_get_value_cansleep(gpio)); mutex_unlock(&sysfs_lock); return status;
gpiolib can export GPIOs to userspace via sysfs. This patch modifies the gpio_value_show() so that any non-zero value is explicitly printed as "1", rather than whatever numerical value the lower-level driver returns. Signed-off-by: Steve Falco <sfalco at harris.com> ---