diff mbox

[v2,2/3] postgresql: remove devfiles from target

Message ID 1407938231-22544-2-git-send-email-bos@je-eigen-domein.nl
State Accepted
Headers show

Commit Message

Floris Bos Aug. 13, 2014, 1:57 p.m. UTC 
Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/postgresql/postgresql.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Aug. 17, 2014, 7:17 p.m. UTC | #1 
Dear Floris Bos,

On Wed, 13 Aug 2014 15:57:10 +0200, Floris Bos wrote:
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> ---
>  package/postgresql/postgresql.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
> index dd2e678..19f9163 100644
> --- a/package/postgresql/postgresql.mk
> +++ b/package/postgresql/postgresql.mk
> @@ -52,6 +52,7 @@ endef
>  
>  define POSTGRESQL_INSTALL_TARGET_FIXUP
>  	$(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/pgsql
> +	$(RM) -rf $(TARGET_DIR)/usr/lib/postgresql/pgxs
>  endef
>  
>  POSTGRESQL_POST_INSTALL_TARGET_HOOKS += POSTGRESQL_INSTALL_TARGET_FIXUP

I've applied the patch, thanks. However, I'm not sure to understand
why you're not removing 'pg_config' from the target.

Thanks,

Thomas
Floris Bos Aug. 17, 2014, 7:57 p.m. UTC | #2 
On 08/17/2014 09:17 PM, Thomas Petazzoni wrote:
> On Wed, 13 Aug 2014 15:57:10 +0200, Floris Bos wrote:
>> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
>> ---
>>   package/postgresql/postgresql.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
>> index dd2e678..19f9163 100644
>> --- a/package/postgresql/postgresql.mk
>> +++ b/package/postgresql/postgresql.mk
>> @@ -52,6 +52,7 @@ endef
>>   
>>   define POSTGRESQL_INSTALL_TARGET_FIXUP
>>   	$(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/pgsql
>> +	$(RM) -rf $(TARGET_DIR)/usr/lib/postgresql/pgxs
>>   endef
>>   
>>   POSTGRESQL_POST_INSTALL_TARGET_HOOKS += POSTGRESQL_INSTALL_TARGET_FIXUP
> I've applied the patch, thanks. However, I'm not sure to understand
> why you're not removing 'pg_config' from the target.

Thomas DS mentioned that having "POSTGRESQL_CONFIG_SCRIPTS = pg_config" 
also causes automatic removal from the target
And have that in the first patch of the patch series that adds the fake 
pg_config file.


Yours sincerely,

Floris Bos
diff mbox

Patch

diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index dd2e678..19f9163 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -52,6 +52,7 @@  endef
 
 define POSTGRESQL_INSTALL_TARGET_FIXUP
 	$(INSTALL) -dm 0700 $(TARGET_DIR)/var/lib/pgsql
+	$(RM) -rf $(TARGET_DIR)/usr/lib/postgresql/pgxs
 endef
 
 POSTGRESQL_POST_INSTALL_TARGET_HOOKS += POSTGRESQL_INSTALL_TARGET_FIXUP