Patchwork cifs: don't use CIFSGetSrvInodeNumber in is_path_accessible

mail settings
Submitter Jeff Layton
Date Nov. 9, 2009, 12:39 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/37953/
State New
Headers show


Jeff Layton - Nov. 9, 2009, 12:39 a.m.
Because it's lighter weight, CIFS tries to use CIFSGetSrvInodeNumber to
verify the accessibility of the root inode and then falls back to doing a
full QPathInfo if that fails with -EOPNOTSUPP. I have at least a report
of a server that returns NT_STATUS_INTERNAL_ERROR rather than something
that translates to EOPNOTSUPP.

Rather than trying to be clever with that call, just have
is_path_accessible do a normal QPathInfo. That call is widely
supported and it shouldn't increase the overhead significantly.

Cc: Stable <>
Signed-off-by: Jeff Layton <>
Signed-off-by: Steve French <>
 fs/cifs/connect.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)


diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b090980..63ea83f 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2220,16 +2220,8 @@  is_path_accessible(int xid, struct cifsTconInfo *tcon,
 		   struct cifs_sb_info *cifs_sb, const char *full_path)
 	int rc;
-	__u64 inode_num;
 	FILE_ALL_INFO *pfile_info;
-	rc = CIFSGetSrvInodeNumber(xid, tcon, full_path, &inode_num,
-				   cifs_sb->local_nls,
-				   cifs_sb->mnt_cifs_flags &
-	if (rc != -EOPNOTSUPP)
-		return rc;
 	pfile_info = kmalloc(sizeof(FILE_ALL_INFO), GFP_KERNEL);
 	if (pfile_info == NULL)
 		return -ENOMEM;