From patchwork Sun Nov 8 20:05:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Halasa X-Patchwork-Id: 37940 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9753CB6F2B for ; Mon, 9 Nov 2009 07:05:11 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbZKHUFD (ORCPT ); Sun, 8 Nov 2009 15:05:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754607AbZKHUFD (ORCPT ); Sun, 8 Nov 2009 15:05:03 -0500 Received: from khc.piap.pl ([195.187.100.11]:44792 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753396AbZKHUFD convert rfc822-to-8bit (ORCPT ); Sun, 8 Nov 2009 15:05:03 -0500 Received: from intrepid.localdomain (intrepid.localdomain [10.0.0.2]) by khc.piap.pl (Postfix) with ESMTP id 588B595AC; Sun, 8 Nov 2009 21:05:06 +0100 (CET) From: Krzysztof Halasa To: linux-ide@vger.kernel.org, lkml Subject: 16-bit operation of PATA_CS5536? Date: Sun, 08 Nov 2009 21:05:05 +0100 Message-ID: MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org I wonder why isn't the PATA CS5536 driver using 32-bit ops. Does the following make any sense? It seems to work on my IXP425-based router. Signed-off-by: Krzysztof Hałasa --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/ata/pata_cs5536.c +++ b/drivers/ata/pata_cs5536.c @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = { }; static struct ata_port_operations cs5536_port_ops = { - .inherits = &ata_bmdma_port_ops, + .inherits = &ata_bmdma32_port_ops, .cable_detect = cs5536_cable_detect, .set_piomode = cs5536_set_piomode, .set_dmamode = cs5536_set_dmamode,