Patchwork [01/75] netx: declare MODULE_FIRMWARE

login
register
mail settings
Submitter Ben Hutchings
Date Nov. 7, 2009, 9:37 p.m.
Message ID <1257629856.15927.370.camel@localhost>
Download mbox | patch
Permalink /patch/37920/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Nov. 7, 2009, 9:37 p.m.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
Note that the filenames are generated in xc_request_firmware(), defined
in arch/arm/mach-netx/xc.c.  I'm not sure whether it's actually worth
doing this for a platform driver.

Ben.

 drivers/net/netx-eth.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Sascha Hauer - Nov. 10, 2009, 7:36 a.m.
On Sat, Nov 07, 2009 at 09:37:36PM +0000, Ben Hutchings wrote:
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> Note that the filenames are generated in xc_request_firmware(), defined
> in arch/arm/mach-netx/xc.c.  I'm not sure whether it's actually worth
> doing this for a platform driver.

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> 
> Ben.
> 
>  drivers/net/netx-eth.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/netx-eth.c b/drivers/net/netx-eth.c
> index 9f42354..a0d65f5 100644
> --- a/drivers/net/netx-eth.c
> +++ b/drivers/net/netx-eth.c
> @@ -510,3 +510,6 @@ module_exit(netx_eth_cleanup);
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:" CARDNAME);
> +MODULE_FIRMWARE("xc0.bin");
> +MODULE_FIRMWARE("xc1.bin");
> +MODULE_FIRMWARE("xc2.bin");
> -- 
> 1.6.5.2
> 
> 
> 
>
David Miller - Nov. 11, 2009, 4:31 a.m.
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sat, 07 Nov 2009 21:37:36 +0000

> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/netx-eth.c b/drivers/net/netx-eth.c
index 9f42354..a0d65f5 100644
--- a/drivers/net/netx-eth.c
+++ b/drivers/net/netx-eth.c
@@ -510,3 +510,6 @@  module_exit(netx_eth_cleanup);
 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:" CARDNAME);
+MODULE_FIRMWARE("xc0.bin");
+MODULE_FIRMWARE("xc1.bin");
+MODULE_FIRMWARE("xc2.bin");