diff mbox

[GSoC] the separate option for all dimensions

Message ID CABGF_gcokSE-_OnJKH01ZOLTBYMyPaA7eiwfQnHt8LD9qZQn-w@mail.gmail.com
State New
Headers show

Commit Message

Roman Gareev Aug. 12, 2014, 6:15 a.m. UTC 
> Checking for this specific AST may cause failures with future versions of
> isl that choose a different schedule. Could you write a regular expression
> that checks that there is no if-condition contained in a for loop? I think
> this best models the issue that was addressed in the original bug report.

I’ve implemented this in the attached patch. Is it fine for trunk?

Comments

Tobias Grosser Aug. 12, 2014, 7:22 a.m. UTC | #1 
On August 12, 2014 8:15:34 AM CEST, Roman Gareev <gareevroman@gmail.com> wrote:
>> Checking for this specific AST may cause failures with future
>versions of
>> isl that choose a different schedule. Could you write a regular
>expression
>> that checks that there is no if-condition contained in a for loop? I
>think
>> this best models the issue that was addressed in the original bug
>report.
>
>I’ve implemented this in the attached patch. Is it fine for trunk?

LGTM. 

Thanks
diff mbox

Patch

Index: gcc/testsuite/gcc.dg/graphite/pr35356-2.c
===================================================================
--- gcc/testsuite/gcc.dg/graphite/pr35356-2.c	(revision 213773)
+++ gcc/testsuite/gcc.dg/graphite/pr35356-2.c	(working copy)
@@ -1,4 +1,4 @@ 
-/* { dg-options "-O2 -fgraphite-identity -fdump-tree-graphite-all" } */
+/* { dg-options "-O2 -fgraphite-identity -fdump-tree-graphite-all  -fgraphite-code-generator=isl" } */
 
 int a[100];
 
@@ -38,7 +38,5 @@ 
 
 */
 
-
-/* { dg-final { scan-tree-dump-times "MIN_EXPR\[^\\n\\r]*;" 4 "graphite" } } */
-/* { dg-final { scan-tree-dump-times "MAX_EXPR\[^\\n\\r]*;" 4 "graphite" } } */
+/* { dg-final { scan-tree-dump-times "for\[^\n\]+\n\[^\n\]+if" 0 "graphite" } } */
 /* { dg-final { cleanup-tree-dump "graphite" } } */