Message ID | 1407747189-7936-9-git-send-email-zhang.zhanghailiang@huawei.com |
---|---|
State | New |
Headers | show |
zhanghailiang writes: > The function fopen() may fail, so check its return value. > > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > Signed-off-by: Li Liu <john.liuli@huawei.com> > --- > tests/bios-tables-test.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 045eb27..28ec28d 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -790,6 +790,11 @@ int main(int argc, char *argv[]) > const char *arch = qtest_get_arch(); > FILE *f = fopen(disk, "w"); > int ret; > + > + if (f == NULL) { > + fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno)); > + return -1; > + } if (!f) would also be acceptable short-hand. Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > fwrite(boot_sector, 1, sizeof boot_sector, f); > fclose(f);
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 045eb27..28ec28d 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -790,6 +790,11 @@ int main(int argc, char *argv[]) const char *arch = qtest_get_arch(); FILE *f = fopen(disk, "w"); int ret; + + if (f == NULL) { + fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno)); + return -1; + } fwrite(boot_sector, 1, sizeof boot_sector, f); fclose(f);