| Message ID | 1407687554-14539-1-git-send-email-linux@roeck-us.net |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Grumble. Headline should be s/ugg/ucc, obviously. Guenter On 08/10/2014 09:19 AM, Guenter Roeck wrote: > powerpc:mpc83xx_defconfig and other builds fail with > > drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': > drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->tbi_node); > ^ > drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->phy_node); > ^ > > Introduced by commit "net: ucc_geth: drop acquired references in probe error > path and remove". > >>From the context, it appears that the variable is named ug_info. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > Only seen in -next. > > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c > index d6b64e3..3cf0478 100644 > --- a/drivers/net/ethernet/freescale/ucc_geth.c > +++ b/drivers/net/ethernet/freescale/ucc_geth.c > @@ -3924,8 +3924,8 @@ static int ucc_geth_remove(struct platform_device* ofdev) > unregister_netdev(dev); > free_netdev(dev); > ucc_geth_memclean(ugeth); > - of_node_put(ugeth->info->tbi_node); > - of_node_put(ugeth->info->phy_node); > + of_node_put(ugeth->ug_info->tbi_node); > + of_node_put(ugeth->ug_info->phy_node); > > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Guenter, On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote: > powerpc:mpc83xx_defconfig and other builds fail with > > drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': > drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->tbi_node); > ^ > drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: > 'struct ucc_geth_private' has no member named 'info' > of_node_put(ugeth->info->phy_node); > ^ > > Introduced by commit "net: ucc_geth: drop acquired references in probe error > path and remove". > > From the context, it appears that the variable is named ug_info. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > Only seen in -next. My patch was only sent just now, but it has the subject right: http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de Another upside is that it contains a Fixes: header. Other than that my patch is the same. In case davem picks up yours: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards and thanks Uwe
On 08/10/2014 11:36 AM, Uwe Kleine-König wrote: > Hello Guenter, > > On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote: >> powerpc:mpc83xx_defconfig and other builds fail with >> >> drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': >> drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: >> 'struct ucc_geth_private' has no member named 'info' >> of_node_put(ugeth->info->tbi_node); >> ^ >> drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: >> 'struct ucc_geth_private' has no member named 'info' >> of_node_put(ugeth->info->phy_node); >> ^ >> >> Introduced by commit "net: ucc_geth: drop acquired references in probe error >> path and remove". >> >> From the context, it appears that the variable is named ug_info. >> >> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> Only seen in -next. > My patch was only sent just now, but it has the subject right: > Excellent. > http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de > The link doesn't seem to work for some reason. > Another upside is that it contains a Fixes: header. > Even better. I need to start using that. > Other than that my patch is the same. In case davem picks up yours: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > I don't need the glory ;-). Dave, please pick Uwe's patch. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Guenter, On Sun, Aug 10, 2014 at 11:42:41AM -0700, Guenter Roeck wrote: > On 08/10/2014 11:36 AM, Uwe Kleine-König wrote: > >On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote: > >>powerpc:mpc83xx_defconfig and other builds fail with > >> > >>drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': > >>drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: > >> 'struct ucc_geth_private' has no member named 'info' > >> of_node_put(ugeth->info->tbi_node); > >> ^ > >>drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: > >> 'struct ucc_geth_private' has no member named 'info' > >> of_node_put(ugeth->info->phy_node); > >> ^ > >> > >>Introduced by commit "net: ucc_geth: drop acquired references in probe error > >>path and remove". > >> > >> From the context, it appears that the variable is named ug_info. > >> > >>Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > >>Signed-off-by: Guenter Roeck <linux@roeck-us.net> > >>--- > >>Only seen in -next. > >My patch was only sent just now, but it has the subject right: > > > Excellent. > > > http://mid.gmane.org/1407695525-32227-1-git-send-email-u.kleine-koenig@pengutronix.de > > > The link doesn't seem to work for some reason. It didn't work for me when I sent the mail either. I thought gmane will have indexed the mail in a few minutes though. Gmane is broken somehow, when I follow the Subject link of http://article.gmane.org/gmane.linux.network/326013 I also get a No such article page?! :-( http://patchwork.ozlabs.org/patch/378854/ is a link that works for me. Best regards Uwe
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index d6b64e3..3cf0478 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -3924,8 +3924,8 @@ static int ucc_geth_remove(struct platform_device* ofdev) unregister_netdev(dev); free_netdev(dev); ucc_geth_memclean(ugeth); - of_node_put(ugeth->info->tbi_node); - of_node_put(ugeth->info->phy_node); + of_node_put(ugeth->ug_info->tbi_node); + of_node_put(ugeth->ug_info->phy_node); return 0; }
powerpc:mpc83xx_defconfig and other builds fail with drivers/net/ethernet/freescale/ucc_geth.c: In function 'ucc_geth_remove': drivers/net/ethernet/freescale/ucc_geth.c:3927:19: error: 'struct ucc_geth_private' has no member named 'info' of_node_put(ugeth->info->tbi_node); ^ drivers/net/ethernet/freescale/ucc_geth.c:3928:19: error: 'struct ucc_geth_private' has no member named 'info' of_node_put(ugeth->info->phy_node); ^ Introduced by commit "net: ucc_geth: drop acquired references in probe error path and remove". From the context, it appears that the variable is named ug_info. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- Only seen in -next. drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)