| Message ID | 1407510572-20603-3-git-send-email-Anton.Kolesov@synopsys.com |
|---|---|
| State | Superseded |
| Headers | show |
Anton, All, On 2014-08-08 19:09 +0400, Anton Kolesov spake thusly: > Libftdi requires GCC built-in atomic functions which are architecture specific > and may not be implemented. > > This fixes: > http://autobuild.buildroot.net/results/6cb25ed954840109c9d0e582e922b0ba9d07e174/ > > Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> However, I do have a small eye-candy comment to make, see below... [--SNIP--] > diff --git a/package/openocd/Config.in b/package/openocd/Config.in > index 7f96ef8..e692d2d 100644 > --- a/package/openocd/Config.in > +++ b/package/openocd/Config.in > @@ -14,11 +14,15 @@ comment "Adapters" > > config BR2_PACKAGE_OPENOCD_FT2XXX > bool "FT2xxx/FT4xxx Based JTAG Programmer" > + depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # libftdi > select BR2_PACKAGE_LIBFTDI > help > Enable building support for FT2232 based devices > using the libftdi driver, opensource alternate of FTD2XX > > +comment "FT2232 support needs a toolchain w/ atomic intrinsics" I'd prefer we keep the same title for comment and options, such as: comment "FT2xxx/FT4xxx support needs a toolchain w/ atomic intrinsics" This can be fixed by whoever commits that, I guess no need to resend. Regards, Yann E. MORIN. > + depends on !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS > + > config BR2_PACKAGE_OPENOCD_JLINK > bool "Segger J-Link JTAG Programmer" > help > -- > 1.8.4.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/libftdi/Config.in b/package/libftdi/Config.in index dc81514..ce65158 100644 --- a/package/libftdi/Config.in +++ b/package/libftdi/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_LIBFTDI bool "libftdi" depends on BR2_TOOLCHAIN_HAS_THREADS # libusb + depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS select BR2_PACKAGE_LIBUSB select BR2_PACKAGE_LIBUSB_COMPAT help @@ -18,5 +19,5 @@ config BR2_PACKAGE_LIBTFDI_CPP endif # BR2_PACKAGE_LIBFTDI -comment "libftdi needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "libftdi needs a toolchain w/ threads, atomic intrinsics" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS diff --git a/package/openocd/Config.in b/package/openocd/Config.in index 7f96ef8..e692d2d 100644 --- a/package/openocd/Config.in +++ b/package/openocd/Config.in @@ -14,11 +14,15 @@ comment "Adapters" config BR2_PACKAGE_OPENOCD_FT2XXX bool "FT2xxx/FT4xxx Based JTAG Programmer" + depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # libftdi select BR2_PACKAGE_LIBFTDI help Enable building support for FT2232 based devices using the libftdi driver, opensource alternate of FTD2XX +comment "FT2232 support needs a toolchain w/ atomic intrinsics" + depends on !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS + config BR2_PACKAGE_OPENOCD_JLINK bool "Segger J-Link JTAG Programmer" help
Libftdi requires GCC built-in atomic functions which are architecture specific and may not be implemented. This fixes: http://autobuild.buildroot.net/results/6cb25ed954840109c9d0e582e922b0ba9d07e174/ Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> --- package/libftdi/Config.in | 5 +++-- package/openocd/Config.in | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-)