Message ID | 1407415749-19978-4-git-send-email-Julia.Lawall@lip6.fr |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, 7 Aug 2014 14:49:07 +0200 Julia Lawall <Julia.Lawall@lip6.fr> wrote: ... > drivers/atm/solos-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c > index 943cf0d..7652e8d 100644 > --- a/drivers/atm/solos-pci.c > +++ b/drivers/atm/solos-pci.c > @@ -1278,6 +1278,7 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id) > card->dma_bounce = kmalloc(card->nr_ports * BUF_SIZE, GFP_KERNEL); > if (!card->dma_bounce) { > dev_warn(&card->dev->dev, "Failed to allocate DMA bounce buffers\n"); > + err = -ENOMEM; > /* Fallback to MMIO doesn't work */ > goto out_unmap_both; > } > Acked-by: Chas Williams <chas@cmf.nrl.navy.mil> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Thu, 7 Aug 2014 14:49:07 +0200 > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Convert a zero return value on error to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 943cf0d..7652e8d 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -1278,6 +1278,7 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id) card->dma_bounce = kmalloc(card->nr_ports * BUF_SIZE, GFP_KERNEL); if (!card->dma_bounce) { dev_warn(&card->dev->dev, "Failed to allocate DMA bounce buffers\n"); + err = -ENOMEM; /* Fallback to MMIO doesn't work */ goto out_unmap_both; }