Patchwork powerpc: remove non-dependent load fsl_booke PTE_64BIT

login
register
mail settings
Submitter Milton Miller
Date Oct. 10, 2008, 11:56 a.m.
Message ID <patch-fsl-1@bga.com>
Download mbox | patch
Permalink /patch/3777/
State Accepted
Commit 9bd54d185ab6c73f0cbd97b9f048394a3462193b
Headers show

Comments

Milton Miller - Oct. 10, 2008, 11:56 a.m.
b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
to order the load of upper and lower halfs of the pte, but only
adjusted whitespace instead of deleting the old load in the iside
handler, letting the hardware see the non-dependent load.

This patch removes the extra load.

Signed-off-by: Milton Miller <miltonm@bga.com>
---
Kumar, I think this is right from my inspection, please review.
Kumar Gala - Oct. 10, 2008, 1:05 p.m.
On Oct 10, 2008, at 6:56 AM, Milton Miller wrote:

> b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
> to order the load of upper and lower halfs of the pte, but only
> adjusted whitespace instead of deleting the old load in the iside
> handler, letting the hardware see the non-dependent load.
>
> This patch removes the extra load.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> Kumar, I think this is right from my inspection, please review.

good catch, thanks.

- k
Kumar Gala - Oct. 10, 2008, 1:07 p.m.
On Oct 10, 2008, at 6:56 AM, Milton Miller wrote:

> b38fd42ff46a4a31dced8533e8a6e549693500b6 added false dependencys
> to order the load of upper and lower halfs of the pte, but only
> adjusted whitespace instead of deleting the old load in the iside
> handler, letting the hardware see the non-dependent load.
>
> This patch removes the extra load.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> Kumar, I think this is right from my inspection, please review.

applied

- k

Patch

Index: next.git/arch/powerpc/kernel/head_fsl_booke.S
===================================================================
--- next.git.orig/arch/powerpc/kernel/head_fsl_booke.S	2008-10-05 02:40:38.000000000 -0500
+++ next.git/arch/powerpc/kernel/head_fsl_booke.S	2008-10-05 02:40:58.000000000 -0500
@@ -658,10 +658,6 @@  interrupt_base:
 
 	bne	2f			/* Bail if permission mismach */
 
-#ifdef CONFIG_PTE_64BIT
-	lwz	r13,0(r12)
-#endif
-
 	/* Jump to common TLB load point */
 	b	finish_tlb_load