Patchwork virtio-blk: Pass read errors to the guest

login
register
mail settings
Submitter Kevin Wolf
Date Nov. 5, 2009, 12:08 p.m.
Message ID <1257422939-5698-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/37755/
State New
Headers show

Comments

Kevin Wolf - Nov. 5, 2009, 12:08 p.m.
We need to signal not only write errors, but also read errors to the guest
driver. This fixes a regression introduced by 869a5c6d.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/virtio-blk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 2630b99..dd196df 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -127,7 +127,7 @@  static void virtio_blk_rw_complete(void *opaque, int ret)
             return;
     }
 
-    virtio_blk_req_complete(req, VIRTIO_BLK_S_OK);
+    virtio_blk_req_complete(req, ret ? VIRTIO_BLK_S_IOERR : VIRTIO_BLK_S_OK);
 }
 
 static void virtio_blk_flush_complete(void *opaque, int ret)