Patchwork [13/16] powerpc smp: no need to set_need_resched in resched ipi

login
register
mail settings
Submitter Milton Miller
Date Oct. 10, 2008, 11:56 a.m.
Message ID <patch-ipi-1@bga.com>
Download mbox | patch
Permalink /patch/3774/
State Accepted, archived
Commit 22d660ffd0db8d136b122751287d186e869ca474
Headers show

Comments

Milton Miller - Oct. 10, 2008, 11:56 a.m.
The code was asking "Do we have to do this?", and according to x86 and s390
the answer is no, the scheduler will do it before calling the arch hook.

Signed-off-by: Milton Miller <miltonm@bga.com>

Patch

Index: next.git/arch/powerpc/kernel/smp.c
===================================================================
--- next.git.orig/arch/powerpc/kernel/smp.c	2008-10-04 22:09:36.000000000 -0500
+++ next.git/arch/powerpc/kernel/smp.c	2008-10-04 22:12:32.000000000 -0500
@@ -101,8 +101,7 @@  void smp_message_recv(int msg)
 		generic_smp_call_function_interrupt();
 		break;
 	case PPC_MSG_RESCHEDULE:
-		/* XXX Do we have to do this? */
-		set_need_resched();
+		/* we notice need_resched on exit */
 		break;
 	case PPC_MSG_CALL_FUNC_SINGLE:
 		generic_smp_call_function_single_interrupt();