diff mbox

patch to fix PR 61923

Message ID 53E24E24.4070003@redhat.com
State New
Headers show

Commit Message

Vladimir Makarov Aug. 6, 2014, 3:47 p.m. UTC
The following patch fixes PR61923.  The details of the problem can be 
found on

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61923

The patch was tested and bootstrapped on x86/x86-64.

The patch has been committed as rev. 213674 to gcc-4.9 branch and as 
rev. 213675 to the trunk.

2014-08-06  Vladimir Makarov  <vmakarov@redhat.com>

         PR debug/61923
         * haifa-sched.c (advance_one_cycle): Fix dump.
         (schedule_block): Don't advance cycle if we are already at the
         beginning of the cycle.

2014-08-06  Vladimir Makarov  <vmakarov@redhat.com>

         PR debug/61923
         * gcc.target/i386/pr61923.c: New test.
diff mbox

Patch

Index: haifa-sched.c
===================================================================
--- haifa-sched.c	(revision 213643)
+++ haifa-sched.c	(working copy)
@@ -2972,7 +2972,7 @@  advance_one_cycle (void)
 {
   advance_state (curr_state);
   if (sched_verbose >= 6)
-    fprintf (sched_dump, ";;\tAdvanced a state.\n");
+    fprintf (sched_dump, ";;\tAdvance the current state.\n");
 }
 
 /* Update register pressure after scheduling INSN.  */
@@ -6007,6 +6007,7 @@  schedule_block (basic_block *target_bb,
   modulo_insns_scheduled = 0;
 
   ls.modulo_epilogue = false;
+  ls.first_cycle_insn_p = true;
 
   /* Loop until all the insns in BB are scheduled.  */
   while ((*current_sched_info->schedule_more_p) ())
@@ -6077,7 +6078,6 @@  schedule_block (basic_block *target_bb,
       if (must_backtrack)
 	goto do_backtrack;
 
-      ls.first_cycle_insn_p = true;
       ls.shadows_only_p = false;
       cycle_issued_insns = 0;
       ls.can_issue_more = issue_rate;
@@ -6363,11 +6363,13 @@  schedule_block (basic_block *target_bb,
 	      break;
 	    }
 	}
+      ls.first_cycle_insn_p = true;
     }
   if (ls.modulo_epilogue)
     success = true;
  end_schedule:
-  advance_one_cycle ();
+  if (!ls.first_cycle_insn_p)
+    advance_one_cycle ();
   perform_replacements_new_cycle ();
   if (modulo_ii > 0)
     {
Index: testsuite/gcc.target/i386/pr61923.c
===================================================================
--- testsuite/gcc.target/i386/pr61923.c	(revision 0)
+++ testsuite/gcc.target/i386/pr61923.c	(working copy)
@@ -0,0 +1,36 @@ 
+/* PR debug/61923 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -fcompare-debug" } */
+
+typedef struct
+{
+  struct
+  {
+    struct
+    {
+      char head;
+    } tickets;
+  };
+} arch_spinlock_t;
+struct ext4_map_blocks
+{
+  int m_lblk;
+  int m_len;
+  int m_flags;
+};
+int ext4_da_map_blocks_ei_0;
+void fn1 (int p1, struct ext4_map_blocks *p2)
+{
+  int ret;
+  if (p2->m_flags)
+    {
+      ext4_da_map_blocks_ei_0++;
+      arch_spinlock_t *lock;
+      switch (sizeof *&lock->tickets.head)
+      case 1:
+      asm("" : "+m"(*&lock->tickets.head) : ""(0));
+      __asm__("");
+      ret = 0;
+    }
+  fn2 (p2->m_lblk, p2->m_len);
+}