| Message ID | 1407320706-17440-4-git-send-email-mperttunen@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 08/06/2014 04:25 AM, Mikko Perttunen wrote: > This adds critical trip points to the Jetson TK1 device tree. > The device will do a controlled shutdown when either the CPU, GPU > or MEM thermal zone reaches 101 degrees Celsius. > diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > + thermal-zones { > + cpu { > + trips { ... > + }; > + }; thermal.txt states that a cooling-maps sub-node is mandatory. However, it seems to be missing here. Is the DT binding documentation overly strict, or do we need to add such a node here? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20/08/14 22:44, Stephen Warren wrote: > On 08/06/2014 04:25 AM, Mikko Perttunen wrote: >> This adds critical trip points to the Jetson TK1 device tree. >> The device will do a controlled shutdown when either the CPU, GPU >> or MEM thermal zone reaches 101 degrees Celsius. > >> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > >> + thermal-zones { >> + cpu { >> + trips { > ... >> + }; >> + }; > > thermal.txt states that a cooling-maps sub-node is mandatory. However, > it seems to be missing here. Is the DT binding documentation overly > strict, or do we need to add such a node here? Debatable. I can add an empty one, that's probably the easiest solution. Mikko > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Stephen, On Wed, Aug 20, 2014 at 01:44:00PM -0600, Stephen Warren wrote: > On 08/06/2014 04:25 AM, Mikko Perttunen wrote: > > This adds critical trip points to the Jetson TK1 device tree. > > The device will do a controlled shutdown when either the CPU, GPU > > or MEM thermal zone reaches 101 degrees Celsius. > > > diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > > > + thermal-zones { > > + cpu { > > + trips { > ... > > + }; > > + }; > > thermal.txt states that a cooling-maps sub-node is mandatory. However, > it seems to be missing here. Is the DT binding documentation overly > strict, or do we need to add such a node here? I believe the binding documentation is correct. I believe this driver should still evolve a little bit to accomplish full thermal DT description and include the cooling devices mapping. All the best, -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/21/2014 10:04 AM, Eduardo Valentin wrote: > Stephen, > > On Wed, Aug 20, 2014 at 01:44:00PM -0600, Stephen Warren wrote: >> On 08/06/2014 04:25 AM, Mikko Perttunen wrote: >>> This adds critical trip points to the Jetson TK1 device tree. >>> The device will do a controlled shutdown when either the CPU, GPU >>> or MEM thermal zone reaches 101 degrees Celsius. >> >>> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> >>> + thermal-zones { >>> + cpu { >>> + trips { >> ... >>> + }; >>> + }; >> >> thermal.txt states that a cooling-maps sub-node is mandatory. However, >> it seems to be missing here. Is the DT binding documentation overly >> strict, or do we need to add such a node here? > > I believe the binding documentation is correct. I believe this driver > should still evolve a little bit to accomplish full thermal DT > description and include the cooling devices mapping. > > All the best, Should we hold off applying the Tegra DT until we can actually fill in the cooling aspects, or are you OK with an empty cooling node as Mikko suggested? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts index ee178c4..c6b47b9 100644 --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts @@ -1856,4 +1856,36 @@ <&tegra_car TEGRA124_CLK_EXTERN1>; clock-names = "pll_a", "pll_a_out0", "mclk"; }; + + thermal-zones { + cpu { + trips { + trip@0 { + temperature = <101000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + mem { + trips { + trip@0 { + temperature = <101000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpu { + trips { + trip@0 { + temperature = <101000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; };
This adds critical trip points to the Jetson TK1 device tree. The device will do a controlled shutdown when either the CPU, GPU or MEM thermal zone reaches 101 degrees Celsius. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 32 +++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)