| Message ID | 1407293685-7003-1-git-send-email-Li.Xiubo@freescale.com |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, 2014-08-06 at 10:54 +0800, Xiubo Li wrote: > drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() > drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument > of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", [] > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c [] > @@ -687,9 +687,9 @@ static int i2c_imx_probe(struct platform_device *pdev) > > dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq); > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", > - res->start, res->end); > + (unsigned int)res->start, (unsigned int)res->end); Probably better to use: dev_dbg(&i2c_imx->adapter.dev, "device resources: %pR\n, res); > dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n", > - resource_size(res), res->start); > + (unsigned int)resource_size(res), (unsigned int)res->start); and remove this. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() > > drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument > > of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] > > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", > [] > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > [] > > @@ -687,9 +687,9 @@ static int i2c_imx_probe(struct platform_device *pdev) > > > > dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq); > > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", > > - res->start, res->end); > > + (unsigned int)res->start, (unsigned int)res->end); > > Probably better to use: > > dev_dbg(&i2c_imx->adapter.dev, "device resources: %pR\n, res); > Yes, this is perfect. > > dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n", > > - resource_size(res), res->start); > > + (unsigned int)resource_size(res), (unsigned int)res->start); > > and remove this. > I will follow your advice. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 1d7efa3..ba4ba32 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -687,9 +687,9 @@ static int i2c_imx_probe(struct platform_device *pdev) dev_dbg(&i2c_imx->adapter.dev, "claimed irq %d\n", irq); dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", - res->start, res->end); + (unsigned int)res->start, (unsigned int)res->end); dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n", - resource_size(res), res->start); + (unsigned int)resource_size(res), (unsigned int)res->start); dev_dbg(&i2c_imx->adapter.dev, "adapter name: \"%s\"\n", i2c_imx->adapter.name); dev_info(&i2c_imx->adapter.dev, "IMX I2C adapter registered\n");
drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", ^ drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument of type unsigned int, but argument 5 has type resource_size_t [-Wformat=] drivers/i2c/busses/i2c-imx.c:691:2: warning: format %d expects argument of type int, but argument 4 has type resource_size_t [-Wformat=] dev_dbg(&i2c_imx->adapter.dev, "allocated %d bytes at 0x%x\n", ^ drivers/i2c/busses/i2c-imx.c:691:2: warning: format 0x%x expects argument of type unsigned int, but argument 5 has type resource_size_t [-Wformat=] Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> --- drivers/i2c/busses/i2c-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)