[v2] gcc/testsuite: Disable pr44194-1.c for BE Power64/Linux
diff mbox

Message ID alpine.DEB.1.10.1408052349580.2958@tp.orcam.me.uk
State Accepted
Headers show

Commit Message

Maciej W. Rozycki Aug. 5, 2014, 10:57 p.m. UTC
On Mon, 4 Aug 2014, Joseph S. Myers wrote:

> > except from the newly-added 64-bit little-endian one (according to 
> > LINUX64_DEFAULT_ABI_ELFv2 defined in rs6000/sysv4le.h and then 
> > rs6000_return_in_memory) or where the `-mabi=elfv2' option has been used 
> > (that, regrettably, looks undetectable to me; there's no preprocessor 
> > macro defined one could use to tell the ABIs apart).  The test case 
> 
> The preprocessor macro is _CALL_ELF (defined to 1 or 2 depending on the 
> 64-bit ABI variant in use, or not defined at all for other ABIs).

 D'oh, there's even a predicate procedure in our test framework already to 
cover it.  Thanks for straightening me out, an updated patch follows.  
This scores:

UNSUPPORTED: gcc.dg/pr44194-1.c

in my testing, like the previous version.  OK to apply?

2014-08-05  Maciej W. Rozycki  <macro@codesourcery.com>

	gcc/testsuite/
	* gcc.dg/pr44194-1.c: Also exclude powerpc*-*-linux*, except if
	powerpc_elfv2.

  Maciej

gcc-test-ppc-pr44194.diff

Comments

David Edelsohn Aug. 5, 2014, 11:14 p.m. UTC | #1
On Tue, Aug 5, 2014 at 6:57 PM, Maciej W. Rozycki
<macro@codesourcery.com> wrote:
> On Mon, 4 Aug 2014, Joseph S. Myers wrote:
>
>> > except from the newly-added 64-bit little-endian one (according to
>> > LINUX64_DEFAULT_ABI_ELFv2 defined in rs6000/sysv4le.h and then
>> > rs6000_return_in_memory) or where the `-mabi=elfv2' option has been used
>> > (that, regrettably, looks undetectable to me; there's no preprocessor
>> > macro defined one could use to tell the ABIs apart).  The test case
>>
>> The preprocessor macro is _CALL_ELF (defined to 1 or 2 depending on the
>> 64-bit ABI variant in use, or not defined at all for other ABIs).
>
>  D'oh, there's even a predicate procedure in our test framework already to
> cover it.  Thanks for straightening me out, an updated patch follows.
> This scores:
>
> UNSUPPORTED: gcc.dg/pr44194-1.c
>
> in my testing, like the previous version.  OK to apply?

Okay.

Thanks, David
Maciej W. Rozycki Aug. 6, 2014, 10:03 a.m. UTC | #2
On Wed, 6 Aug 2014, David Edelsohn wrote:

> >  D'oh, there's even a predicate procedure in our test framework already to
> > cover it.  Thanks for straightening me out, an updated patch follows.
> > This scores:
> >
> > UNSUPPORTED: gcc.dg/pr44194-1.c
> >
> > in my testing, like the previous version.  OK to apply?
> 
> Okay.

 Applied, thanks.

  Maciej
Marek Polacek Aug. 6, 2014, noon UTC | #3
On Wed, Aug 06, 2014 at 11:03:02AM +0100, Maciej W. Rozycki wrote:
> On Wed, 6 Aug 2014, David Edelsohn wrote:
> 
> > >  D'oh, there's even a predicate procedure in our test framework already to
> > > cover it.  Thanks for straightening me out, an updated patch follows.
> > > This scores:
> > >
> > > UNSUPPORTED: gcc.dg/pr44194-1.c
> > >
> > > in my testing, like the previous version.  OK to apply?
> > 
> > Okay.
> 
>  Applied, thanks.

I see
ERROR: gcc.dg/pr44194-1.c: unknown dg option: \} for "}"
now (x86_64-unknown-linux-gnu).

	Marek
Maciej W. Rozycki Aug. 6, 2014, 4:11 p.m. UTC | #4
On Wed, 6 Aug 2014, Marek Polacek wrote:

> >  Applied, thanks.
> 
> I see
> ERROR: gcc.dg/pr44194-1.c: unknown dg option: \} for "}"
> now (x86_64-unknown-linux-gnu).

 I pushed a stale version of the patch, sorry.  Fixed up now.

2014-08-06  Maciej W. Rozycki  <macro@codesourcery.com>

	* gcc.dg/pr44194-1.c: Remove an extraneous brace.

  Maciej

Patch
diff mbox

Index: gcc-fsf-trunk-quilt/gcc/testsuite/gcc.dg/pr44194-1.c
===================================================================
--- gcc-fsf-trunk-quilt.orig/gcc/testsuite/gcc.dg/pr44194-1.c	2014-08-04 23:54:08.000000000 +0100
+++ gcc-fsf-trunk-quilt/gcc/testsuite/gcc.dg/pr44194-1.c	2014-08-05 23:35:49.158934812 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile { target { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } } } */
+/* { dg-do compile { target { { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } && { { ! powerpc*-*-linux* } || powerpc_elfv2 } } } } } */
 /* { dg-options "-O2 -fdump-rtl-dse1 -fdump-rtl-final" } */
 
 /* Restrict to 64-bit targets since 32-bit targets usually return small