| Message ID | 1407244453-3082-1-git-send-email-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Dear Alex Bennée, On Tue, 5 Aug 2014 14:14:13 +0100, Alex Bennée wrote: > There is no real reason to disable the building of GDB. I suspect the > original patch (be084204) which added the restriction did so not > realising that AArch64 has had thread support in it's toolchain for some > time. be084204 did not add the AArch64 exception: it only made sure the comments about threads being needed would not be shown on AArch64, because gdb is never available on AArch64. The real commit who made gdb unavailable on AArch64 is 0e49733b306b353aad3a29a2c7a6faf25841ef0b. I believe at the time (April 2013), AArch64 was maybe not supported in the mainline gdb. Therefore, could you check when AArch64 support was added in mainline gdb ? We currently allow selecting either gdb 7.6 and 7.7 in Buildroot. Thanks! Thomas
On Tue, Aug 5, 2014 at 3:20 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Alex Bennée, > > On Tue, 5 Aug 2014 14:14:13 +0100, Alex Bennée wrote: >> There is no real reason to disable the building of GDB. I suspect the >> original patch (be084204) which added the restriction did so not >> realising that AArch64 has had thread support in it's toolchain for some >> time. > > be084204 did not add the AArch64 exception: it only made sure the > comments about threads being needed would not be shown on AArch64, > because gdb is never available on AArch64. > > The real commit who made gdb unavailable on AArch64 is > 0e49733b306b353aad3a29a2c7a6faf25841ef0b. I believe at the time (April > 2013), AArch64 was maybe not supported in the mainline gdb. > > Therefore, could you check when AArch64 support was added in mainline > gdb ? We currently allow selecting either gdb 7.6 and 7.7 in Buildroot. AArch64 has been supported since gdb 7.6 (although 7.8 is much nicer to use due to bug fixes).
Will Newton writes: > On Tue, Aug 5, 2014 at 3:20 PM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: >> Dear Alex Bennée, >> >> On Tue, 5 Aug 2014 14:14:13 +0100, Alex Bennée wrote: >>> There is no real reason to disable the building of GDB. I suspect the >>> original patch (be084204) which added the restriction did so not >>> realising that AArch64 has had thread support in it's toolchain for some >>> time. >> >> be084204 did not add the AArch64 exception: it only made sure the >> comments about threads being needed would not be shown on AArch64, >> because gdb is never available on AArch64. >> >> The real commit who made gdb unavailable on AArch64 is >> 0e49733b306b353aad3a29a2c7a6faf25841ef0b. I believe at the time (April >> 2013), AArch64 was maybe not supported in the mainline gdb. My mistake, I got lost in the maze of GDB Config.in changes. >> >> Therefore, could you check when AArch64 support was added in mainline >> gdb ? We currently allow selecting either gdb 7.6 and 7.7 in Buildroot. > > AArch64 has been supported since gdb 7.6 (although 7.8 is much nicer > to use due to bug fixes). I'll resubmit with a re-worded commit message.
Dear Alex Bennée, On Wed, 06 Aug 2014 09:23:58 +0100, Alex Bennée wrote: > >> The real commit who made gdb unavailable on AArch64 is > >> 0e49733b306b353aad3a29a2c7a6faf25841ef0b. I believe at the time (April > >> 2013), AArch64 was maybe not supported in the mainline gdb. > > My mistake, I got lost in the maze of GDB Config.in changes. No problem! > >> Therefore, could you check when AArch64 support was added in mainline > >> gdb ? We currently allow selecting either gdb 7.6 and 7.7 in Buildroot. > > > > AArch64 has been supported since gdb 7.6 (although 7.8 is much nicer > > to use due to bug fixes). > > I'll resubmit with a re-worded commit message. Great, thanks a lot! Thomas
diff --git a/package/gdb/Config.in b/package/gdb/Config.in index cc2469e..bfbc8d8 100644 --- a/package/gdb/Config.in +++ b/package/gdb/Config.in @@ -1,5 +1,5 @@ comment "gdb/gdbserver needs a toolchain w/ threads, threads debug" - depends on !BR2_aarch64 && !BR2_nios2 + depends on !BR2_nios2 depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HAS_THREADS_DEBUG config BR2_PACKAGE_GDB @@ -10,7 +10,7 @@ config BR2_PACKAGE_GDB select BR2_PACKAGE_GDB_SERVER if \ (!BR2_PACKAGE_GDB_DEBUGGER && !BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY) depends on BR2_TOOLCHAIN_HAS_THREADS && BR2_TOOLCHAIN_HAS_THREADS_DEBUG - depends on !BR2_aarch64 && !BR2_nios2 + depends on !BR2_nios2 help GDB, the GNU Project debugger, allows you to see what is going on `inside' another program while it executes -- or
There is no real reason to disable the building of GDB. I suspect the original patch (be084204) which added the restriction did so not realising that AArch64 has had thread support in it's toolchain for some time. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- package/gdb/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)