Patchwork [v1,1/2] devicetree: bindings: improve description for GPIO assisted NAND flash

login
register
mail settings
Submitter Gerhard Sittig
Date Aug. 5, 2014, 8:37 a.m.
Message ID <1407227846-3257-1-git-send-email-gsi@denx.de>
Download mbox | patch
Permalink /patch/376618/
State Accepted
Commit f861a9253e7f456d870f8dd46bdde2ac02149bc6
Headers show

Comments

Gerhard Sittig - Aug. 5, 2014, 8:37 a.m.
Expand the description of the 'gpios' property in the GPIO assisted
NAND flash binding, to explicitly list the required GPIO pin references
and their order.

Update the example section to individually bracket the GPIO references,
and capitalize the signal names for improved readability.

Signed-off-by: Gerhard Sittig <gsi@denx.de>
---
 .../devicetree/bindings/mtd/gpio-control-nand.txt        |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
Brian Norris - Nov. 5, 2014, 7:56 a.m.
On Tue, Aug 05, 2014 at 10:37:25AM +0200, Gerhard Sittig wrote:
> Expand the description of the 'gpios' property in the GPIO assisted
> NAND flash binding, to explicitly list the required GPIO pin references
> and their order.
> 
> Update the example section to individually bracket the GPIO references,
> and capitalize the signal names for improved readability.
> 
> Signed-off-by: Gerhard Sittig <gsi@denx.de>

Applied both to l2-mtd.git.

Brian

Patch

diff --git a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
index 36ef07d3c90f..af8915b41ccf 100644
--- a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
+++ b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
@@ -11,8 +11,8 @@  Required properties:
   are made in native endianness.
 - #address-cells, #size-cells : Must be present if the device has sub-nodes
   representing partitions.
-- gpios : specifies the gpio pins to control the NAND device.  nwp is an
-  optional gpio and may be set to 0 if not present.
+- gpios : Specifies the GPIO pins to control the NAND device.  The order of
+  GPIO references is:  RDY, nCE, ALE, CLE, and an optional nWP.
 
 Optional properties:
 - bank-width : Width (in bytes) of the device.  If not present, the width
@@ -35,11 +35,11 @@  gpio-nand@1,0 {
 	reg = <1 0x0000 0x2>;
 	#address-cells = <1>;
 	#size-cells = <1>;
-	gpios = <&banka 1 0	/* rdy */
-		 &banka 2 0 	/* nce */
-		 &banka 3 0 	/* ale */
-		 &banka 4 0 	/* cle */
-		 0		/* nwp */>;
+	gpios = <&banka 1 0>,	/* RDY */
+		<&banka 2 0>, 	/* nCE */
+		<&banka 3 0>, 	/* ALE */
+		<&banka 4 0>, 	/* CLE */
+		<0>;		/* nWP */
 
 	partition@0 {
 	...