@@ -433,7 +433,8 @@ int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle)
{
acpi_handle bridge_handle, parent_handle;
- if (!(bridge_handle = acpi_pci_get_bridge_handle(pbus)))
+ bridge_handle = acpi_pci_get_bridge_handle(pbus);
+ if (!bridge_handle)
return 0;
if ((ACPI_FAILURE(acpi_get_parent(handle, &parent_handle))))
return 0;
@@ -237,8 +237,9 @@ static int zt5550_hc_init_one (struct pci_dev *pdev, const struct pci_device_id
dbg("registered controller");
/* Look for first device matching cPCI bus's bridge vendor and device IDs */
- if (!(bus0_dev = pci_get_device(PCI_VENDOR_ID_DEC,
- PCI_DEVICE_ID_DEC_21154, NULL))) {
+ bus0_dev = pci_get_device(PCI_VENDOR_ID_DEC,
+ PCI_DEVICE_ID_DEC_21154, NULL);
+ if (!bus0_dev) {
status = -ENODEV;
goto init_register_error;
}
The following Coccinelle semantic patch was used to find and correct cases of assignements in if conditions: @ifassign@ expression var, expr; statement S; @@ - if(!(var = expr)) S + var = expr; + if(!var) S Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com> --- drivers/pci/hotplug/acpi_pcihp.c | 3 ++- drivers/pci/hotplug/cpcihp_zt5550.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-)