From patchwork Sun Aug 3 12:57:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 376004 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2DD201400A3 for ; Sun, 3 Aug 2014 22:57:19 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding:content-type; q=dns; s=default; b=ax1OFYTuY4EyU+FKph8vVTaezVO/0RKrELEI2ahnn0E G+zBXpRM7zJ1FLDp928R1JxC1ulaxZmaq5Ynag0IThjbSFIrEk+dQnC9rXS5bjqQ nBD3Y+M/sNp4Q7u2kPmYMwf9rVkdbHkoK5thW4di16+CwI5zQJtx0kblDsFiXAV8 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding:content-type; s=default; bh=lcRLX0GRrnnGKTe42Yt4GvwN6+M=; b=n1vannQIYdu2q7ts1 qGfFWhi6RceOysV/HrO0LAC4zHYNTVStGjGtwtTS7ziOswmTe0MomEYOkb8MkaF/ 84HwJimErIe22c4mUDHs0QnyEPICEzBJnmMjDCsZympaE4Zl5He9T46J7WZBvaAA Qsu4HVgCOsfpg+oa2k3iQ3I5b0= Received: (qmail 9415 invoked by alias); 3 Aug 2014 12:57:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 9394 invoked by uid 89); 3 Aug 2014 12:57:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org From: Mike Frysinger To: libc-alpha@sourceware.org Cc: Will Newton Subject: Re: [PATCH 1/2] stdlib/tst-setcontext.c: Check for clobbering of signal stack. Date: Sun, 03 Aug 2014 08:57:06 -0400 Message-ID: <1530720.Yn0EdBKC0g@vapier> User-Agent: KMail/4.13.1 (Linux/3.14.2; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1393829881-22691-1-git-send-email-will.newton@linaro.org> References: <1393829881-22691-1-git-send-email-will.newton@linaro.org> MIME-Version: 1.0 On Mon 03 Mar 2014 14:58:00 Will Newton wrote: > + sigaltstack(NULL, &stack_after); incorrect style (and below). fixed with below as obvious. -mike From a1d8c6215d0bcda6985cb383d8c440b03db7253d Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Sun, 3 Aug 2014 08:55:20 -0400 Subject: [PATCH] tst-setcontext: fix style --- stdlib/tst-setcontext.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/stdlib/tst-setcontext.c b/stdlib/tst-setcontext.c index 55984a4..74d5133 100644 --- a/stdlib/tst-setcontext.c +++ b/stdlib/tst-setcontext.c @@ -74,8 +74,8 @@ f2 (void) } void -test_stack(volatile int a, volatile int b, - volatile int c, volatile int d) +test_stack (volatile int a, volatile int b, + volatile int c, volatile int d) { volatile int e = 5; volatile int f = 6; @@ -83,7 +83,7 @@ test_stack(volatile int a, volatile int b, /* Test for cases where getcontext is clobbering the callers stack, including parameters. */ - getcontext(&uc); + getcontext (&uc); if (a != 1) { @@ -147,7 +147,7 @@ main (void) char st1[32768]; stack_t stack_before, stack_after; - sigaltstack(NULL, &stack_before); + sigaltstack (NULL, &stack_before); puts ("making contexts"); if (getcontext (&ctx[1]) != 0) @@ -211,7 +211,7 @@ main (void) puts ("back at main program"); back_in_main = 1; - sigaltstack(NULL, &stack_after); + sigaltstack (NULL, &stack_after); if (was_in_f1 == 0) {