diff mbox

[flasher,V2] Adapt to new U-Boot build commands

Message ID 1406922035-30281-1-git-send-email-swarren@wwwdotorg.org
State Accepted, archived
Headers show

Commit Message

Stephen Warren Aug. 1, 2014, 7:40 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

U-Boot commit 51148790f26e "kconfig: switch to Kconfig" changed the
commands required to configure U-Boot. Adapt the flasher build script
to those changes, in a way that automatically works with either old or
new U-Boot source trees.

Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
--
v2: Check for the modified "make help" output rather than a file added
by commit 51148790f26e. Hopefully this will be more independant from
changes to U-Boot's implementation details.
---
 build | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Stephen Warren Aug. 4, 2014, 4:52 p.m. UTC | #1 
On 08/01/2014 01:40 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> U-Boot commit 51148790f26e "kconfig: switch to Kconfig" changed the
> commands required to configure U-Boot. Adapt the flasher build script
> to those changes, in a way that automatically works with either old or
> new U-Boot source trees.

I have applied this.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/build b/build
index af863dd3b395..b58112e12be2 100755
--- a/build
+++ b/build
@@ -186,7 +186,17 @@  def build_uboot_one_board(boardname):
     out_board_dir = gen_out_board_dir(boardname)
     mkdir(out_board_dir)
 
-    run(uboot_dir, 'make O=' + build_uboot_dir + ' ' + boardname + '_config')
+    # U-Boot commit 51148790f26e "kconfig: switch to Kconfig" changed the
+    # build commands from "make ${board}_config; make" to
+    # "make ${board}_defconfig; make". That commit also introduced some new
+    # text into the "make help" output. Check for that text here in order to
+    # tell how to compile U-Boot:-/
+    ret = subprocess.call('make help 2>/dev/null | grep -q "Configuration targets"', shell=True, cwd=uboot_dir)
+    if ret:
+        config_target_suffix = '_config'
+    else:
+        config_target_suffix = '_defconfig'
+    run(uboot_dir, 'make O=' + build_uboot_dir + ' ' + boardname + config_target_suffix)
     run(uboot_dir, 'make O=' + build_uboot_dir + ' -s ' + makejobs)
 
     import_uboot_one_board(boardname, build_uboot_dir)