| Message ID | 1406892514-27996-1-git-send-email-sachin.kamat@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
On 1 August 2014 16:58, Sachin Kamat <sachin.kamat@samsung.com> wrote: > We get the following error when built as a module. Though the general fix would > be in this case to export the below mentioned symbols, considering that > dw_pcie_host_init is marked with __init and other PCI drivers do not support > modular build, I have disabled building this driver as a module too. > > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> > --- > drivers/pci/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index 8922c37..90f5cca 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC > controller, such as the one emulated by kvmtool. > > config PCIE_SPEAR13XX > - tristate "STMicroelectronics SPEAr PCIe controller" > + bool "STMicroelectronics SPEAr PCIe controller" > depends on ARCH_SPEAR13XX > select PCIEPORTBUS > select PCIE_DW Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, August 04, 2014 4:09 PM, Sachin Kamat wrote: > On 1 August 2014 16:58, Sachin Kamat <sachin.kamat@samsung.com> wrote: > > We get the following error when built as a module. Though the general fix would > > be in this case to export the below mentioned symbols, considering that > > dw_pcie_host_init is marked with __init and other PCI drivers do not support > > modular build, I have disabled building this driver as a module too. > > > > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Reviewed-by: Jingoo Han <jg1.han@samsung.com> In order to use PCI host drivers as the module, we need to do additional works. Actually, it was already discussed in other threads. However, it is not sure that who will do this work. Thanks! Best regards, Jingoo Han > > --- > > drivers/pci/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > index 8922c37..90f5cca 100644 > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC > > controller, such as the one emulated by kvmtool. > > > > config PCIE_SPEAR13XX > > - tristate "STMicroelectronics SPEAr PCIe controller" > > + bool "STMicroelectronics SPEAr PCIe controller" > > depends on ARCH_SPEAR13XX > > select PCIEPORTBUS > > select PCIE_DW > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote: > We get the following error when built as a module. Though the general fix would > be in this case to export the below mentioned symbols, considering that > dw_pcie_host_init is marked with __init and other PCI drivers do not support > modular build, I have disabled building this driver as a module too. > > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for v3.17, thanks! > --- > drivers/pci/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index 8922c37..90f5cca 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC > controller, such as the one emulated by kvmtool. > > config PCIE_SPEAR13XX > - tristate "STMicroelectronics SPEAr PCIe controller" > + bool "STMicroelectronics SPEAr PCIe controller" > depends on ARCH_SPEAR13XX > select PCIEPORTBUS > select PCIE_DW > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 13, 2014 at 11:20:32AM -0600, Bjorn Helgaas wrote: > On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote: > > We get the following error when built as a module. Though the general fix would > > be in this case to export the below mentioned symbols, considering that > > dw_pcie_host_init is marked with __init and other PCI drivers do not support > > modular build, I have disabled building this driver as a module too. > > > > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> > > Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for > v3.17, thanks! Sorry, I misplaced this somehow. I did it again and it's now in my for-linus branch, so it should still make it for v3.17. Sorry about that. > > --- > > drivers/pci/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > index 8922c37..90f5cca 100644 > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC > > controller, such as the one emulated by kvmtool. > > > > config PCIE_SPEAR13XX > > - tristate "STMicroelectronics SPEAr PCIe controller" > > + bool "STMicroelectronics SPEAr PCIe controller" > > depends on ARCH_SPEAR13XX > > select PCIEPORTBUS > > select PCIE_DW > > -- > > 1.8.1.2 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 8922c37..90f5cca 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC controller, such as the one emulated by kvmtool. config PCIE_SPEAR13XX - tristate "STMicroelectronics SPEAr PCIe controller" + bool "STMicroelectronics SPEAr PCIe controller" depends on ARCH_SPEAR13XX select PCIEPORTBUS select PCIE_DW
We get the following error when built as a module. Though the general fix would be in this case to export the below mentioned symbols, considering that dw_pcie_host_init is marked with __init and other PCI drivers do not support modular build, I have disabled building this driver as a module too. ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> --- drivers/pci/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)