diff mbox

[U-Boot,4/7] sunxi-common.h: Don't undef CONFIG_CMD_NET only to redefine it again later

Message ID 1406879207-12322-4-git-send-email-hdegoede@redhat.com
State Accepted
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede Aug. 1, 2014, 7:46 a.m. UTC
config_distro_defaults.h which is include later will redefine CONFIG_CMD_NET,
drop the useless / meaningless undef of it.

While at also move the undef of CONFIG_CMD_FPGA up to directly under the
include of config_cmd_defaults.h, to make it clear that it overwrites
the setting done from config_cmd_defaults.h .

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 include/configs/sunxi-common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Ian Campbell Aug. 4, 2014, 9:20 p.m. UTC | #1
On Fri, 2014-08-01 at 09:46 +0200, Hans de Goede wrote:
> config_distro_defaults.h which is include later will redefine CONFIG_CMD_NET,
> drop the useless / meaningless undef of it.
> 
> While at also move the undef of CONFIG_CMD_FPGA up to directly under the
> include of config_cmd_defaults.h, to make it clear that it overwrites
> the setting done from config_cmd_defaults.h .
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>
diff mbox

Patch

diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index cbe8b40..4c712f3 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -127,6 +127,7 @@ 
 	"bootm_size=0x10000000\0"
 
 #include <config_cmd_default.h>
+#undef CONFIG_CMD_FPGA
 
 #define CONFIG_FAT_WRITE	/* enable write access */
 
@@ -166,9 +167,6 @@ 
 #define CONFIG_SYS_SPL_MALLOC_START	0x4ff00000
 #define CONFIG_SYS_SPL_MALLOC_SIZE	0x00080000	/* 512 KiB */
 
-#undef CONFIG_CMD_FPGA
-#undef CONFIG_CMD_NET
-
 /* I2C */
 #define CONFIG_SPL_I2C_SUPPORT
 #define CONFIG_SYS_I2C