Patchwork [08/25] mlx4_core: fix buggy parsing of reserved eq cap

login
register
mail settings
Submitter Yevgeny Petrilin
Date Nov. 4, 2009, 3:30 p.m.
Message ID <4AF19E2C.6060604@mellanox.co.il>
Download mbox | patch
Permalink /patch/37556/
State Awaiting Upstream
Delegated to: David Miller
Headers show

Comments

Yevgeny Petrilin - Nov. 4, 2009, 3:30 p.m.
Signed-off-by: Liran Liss <liranl@mellanox.co.il>
---
 drivers/net/mlx4/fw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Roland Dreier - Nov. 5, 2009, 8 p.m.
> -	dev_cap->reserved_eqs = 1 << (field & 0xf);
 > +	dev_cap->reserved_eqs = field & 0xf;

This patch looks good to apply right now.  Is it OK for me to make this
"From: Liran Liss <liranl@mellanox.co.il>" and add "Signed-off-by:
Yevgeny Petrilin <yevgenyp@mellanox.co.il>"?

 - R.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yevgeny Petrilin - Nov. 5, 2009, 8:09 p.m.
> > -	dev_cap->reserved_eqs = 1 << (field & 0xf);
> > +	dev_cap->reserved_eqs = field & 0xf;
>
>This patch looks good to apply right now.  Is it OK for me to make this
>"From: Liran Liss <liranl@mellanox.co.il>" and add "Signed-off-by:
>Yevgeny Petrilin <yevgenyp@mellanox.co.il>"?

Yes, but
I am currently working on fixing the patches according to comments
received so far,
And thought to resubmit the entire patch set.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Roland Dreier - Nov. 5, 2009, 8:10 p.m.
> I am currently working on fixing the patches according to comments
 > received so far,
 > And thought to resubmit the entire patch set.

That's a good idea, but you can just drop this one and I'll take it
independent of SRIOV support (since it really is independent).

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/mlx4/fw.c b/drivers/net/mlx4/fw.c
index a63f84a..87eb2d4 100644
--- a/drivers/net/mlx4/fw.c
+++ b/drivers/net/mlx4/fw.c
@@ -243,7 +243,7 @@  int mlx4_QUERY_DEV_CAP(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
 	MLX4_GET(field, outbox, QUERY_DEV_CAP_MAX_MPT_OFFSET);
 	dev_cap->max_mpts = 1 << (field & 0x3f);
 	MLX4_GET(field, outbox, QUERY_DEV_CAP_RSVD_EQ_OFFSET);
-	dev_cap->reserved_eqs = 1 << (field & 0xf);
+	dev_cap->reserved_eqs = field & 0xf;
 	MLX4_GET(field, outbox, QUERY_DEV_CAP_MAX_EQ_OFFSET);
 	dev_cap->max_eqs = 1 << (field & 0xf);
 	MLX4_GET(field, outbox, QUERY_DEV_CAP_RSVD_MTT_OFFSET);