| Message ID | 1406842092-25207-8-git-send-email-emilio@elopez.com.ar |
|---|---|
| State | New |
| Headers | show |
Would it be better to name this "allwinner,sun4i-a10-pll2-clk" instead of "allwinner,sun4i-a10-b-pll2-clk"? By encoding the b in it everyone is going to wonder what to do on the 'c' revision which is the most common revision. The revision based rename would then be from "allwinner,sun4i-a10-pll2-clk" to "allwinner,sun4i-a10-a-pll2-clk". On Thu, Jul 31, 2014 at 5:28 PM, Emilio López <emilio@elopez.com.ar> wrote: > This commit adds the PLL2 definition to the sun4i, sun5i and sun7i > device trees. PLL2 is used to clock audio devices. > > Signed-off-by: Emilio López <emilio@elopez.com.ar> > --- > > Changes from RFC: > * A10 rev A is now supported via the quirk code > > arch/arm/boot/dts/sun4i-a10.dtsi | 8 ++++++++ > arch/arm/boot/dts/sun5i-a10s.dtsi | 8 ++++++++ > arch/arm/boot/dts/sun5i-a13.dtsi | 8 ++++++++ > arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++ > 4 files changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > index 459cb63..c4d4c73 100644 > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > @@ -81,6 +81,14 @@ > clock-output-names = "pll1"; > }; > > + pll2: clk@01c20008 { > + #clock-cells = <1>; > + compatible = "allwinner,sun4i-a10-b-pll2-clk"; > + reg = <0x01c20008 0x4>; > + clocks = <&osc24M>; > + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; > + }; > + > pll4: clk@01c20018 { > #clock-cells = <0>; > compatible = "allwinner,sun4i-a10-pll1-clk"; > diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi > index 24b0ad3..f35aa4d 100644 > --- a/arch/arm/boot/dts/sun5i-a10s.dtsi > +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi > @@ -74,6 +74,14 @@ > clock-output-names = "pll1"; > }; > > + pll2: clk@01c20008 { > + #clock-cells = <1>; > + compatible = "allwinner,sun4i-a10-b-pll2-clk"; > + reg = <0x01c20008 0x4>; > + clocks = <&osc24M>; > + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; > + }; > + > pll4: clk@01c20018 { > #clock-cells = <0>; > compatible = "allwinner,sun4i-a10-pll1-clk"; > diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi > index bf86e65..38b2d77 100644 > --- a/arch/arm/boot/dts/sun5i-a13.dtsi > +++ b/arch/arm/boot/dts/sun5i-a13.dtsi > @@ -75,6 +75,14 @@ > clock-output-names = "pll1"; > }; > > + pll2: clk@01c20008 { > + #clock-cells = <1>; > + compatible = "allwinner,sun4i-a10-b-pll2-clk"; > + reg = <0x01c20008 0x4>; > + clocks = <&osc24M>; > + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; > + }; > + > pll4: clk@01c20018 { > #clock-cells = <0>; > compatible = "allwinner,sun4i-a10-pll1-clk"; > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi > index 4011628..7a6a18c 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -91,6 +91,14 @@ > clock-output-names = "pll1"; > }; > > + pll2: clk@01c20008 { > + #clock-cells = <1>; > + compatible = "allwinner,sun4i-a10-b-pll2-clk"; > + reg = <0x01c20008 0x4>; > + clocks = <&osc24M>; > + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; > + }; > + > pll4: clk@01c20018 { > #clock-cells = <0>; > compatible = "allwinner,sun7i-a20-pll4-clk"; > -- > 2.0.3
On Thu, Jul 31, 2014 at 05:46:09PM -0400, jonsmirl@gmail.com wrote: > Would it be better to name this "allwinner,sun4i-a10-pll2-clk" instead > of "allwinner,sun4i-a10-b-pll2-clk"? By encoding the b in it everyone > is going to wonder what to do on the 'c' revision which is the most > common revision. Not really, the way we works usually is that the compatible is the one from the first SoC that implemented that IP. If the rev C has the same IP than rev B, then we're using the rev B compatible. > > The revision based rename would then be from > "allwinner,sun4i-a10-pll2-clk" to "allwinner,sun4i-a10-a-pll2-clk". Though, I'd agree with you. We should have a single compatible in the DT, a generic one, that would trigger the auto-detection, and might change it to the rev A one, but the rev B doesn't make much sense. Maxime
On Sun, Aug 3, 2014 at 8:50 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Thu, Jul 31, 2014 at 05:46:09PM -0400, jonsmirl@gmail.com wrote: >> Would it be better to name this "allwinner,sun4i-a10-pll2-clk" instead >> of "allwinner,sun4i-a10-b-pll2-clk"? By encoding the b in it everyone >> is going to wonder what to do on the 'c' revision which is the most >> common revision. > > Not really, the way we works usually is that the compatible is the one > from the first SoC that implemented that IP. If the rev C has the same > IP than rev B, then we're using the rev B compatible. > >> >> The revision based rename would then be from >> "allwinner,sun4i-a10-pll2-clk" to "allwinner,sun4i-a10-a-pll2-clk". > > Though, I'd agree with you. We should have a single compatible in the > DT, a generic one, that would trigger the auto-detection, and might > change it to the rev A one, but the rev B doesn't make much sense. I agree. The rev B would make people reading the DT wonder what happened to rev A.
Hi, El 03/08/14 a las 12:55, Chen-Yu Tsai escibió: > On Sun, Aug 3, 2014 at 8:50 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: >> On Thu, Jul 31, 2014 at 05:46:09PM -0400, jonsmirl@gmail.com wrote: >>> Would it be better to name this "allwinner,sun4i-a10-pll2-clk" instead >>> of "allwinner,sun4i-a10-b-pll2-clk"? By encoding the b in it everyone >>> is going to wonder what to do on the 'c' revision which is the most >>> common revision. >> >> Not really, the way we works usually is that the compatible is the one >> from the first SoC that implemented that IP. If the rev C has the same >> IP than rev B, then we're using the rev B compatible. >> >>> >>> The revision based rename would then be from >>> "allwinner,sun4i-a10-pll2-clk" to "allwinner,sun4i-a10-a-pll2-clk". >> >> Though, I'd agree with you. We should have a single compatible in the >> DT, a generic one, that would trigger the auto-detection, and might >> change it to the rev A one, but the rev B doesn't make much sense. > > I agree. The rev B would make people reading the DT wonder what happened > to rev A. Would you like to see "allwinner,sun4i-a10-pll2-clk" on the DT then? Should we document it as a magic property triggering an autodetect on the clock binding document? Cheers! Emilio
On Sun, Aug 03, 2014 at 07:15:00PM -0300, Emilio López wrote: > Hi, > > El 03/08/14 a las 12:55, Chen-Yu Tsai escibió: > >On Sun, Aug 3, 2014 at 8:50 PM, Maxime Ripard > ><maxime.ripard@free-electrons.com> wrote: > >>On Thu, Jul 31, 2014 at 05:46:09PM -0400, jonsmirl@gmail.com wrote: > >>>Would it be better to name this "allwinner,sun4i-a10-pll2-clk" instead > >>>of "allwinner,sun4i-a10-b-pll2-clk"? By encoding the b in it everyone > >>>is going to wonder what to do on the 'c' revision which is the most > >>>common revision. > >> > >>Not really, the way we works usually is that the compatible is the one > >>from the first SoC that implemented that IP. If the rev C has the same > >>IP than rev B, then we're using the rev B compatible. > >> > >>> > >>>The revision based rename would then be from > >>>"allwinner,sun4i-a10-pll2-clk" to "allwinner,sun4i-a10-a-pll2-clk". > >> > >>Though, I'd agree with you. We should have a single compatible in the > >>DT, a generic one, that would trigger the auto-detection, and might > >>change it to the rev A one, but the rev B doesn't make much sense. > > > >I agree. The rev B would make people reading the DT wonder what happened > >to rev A. > > Would you like to see "allwinner,sun4i-a10-pll2-clk" on the DT then? > Should we document it as a magic property triggering an autodetect > on the clock binding document? Yes, and the rev-a one as really only to be used with a rev A SoC, with a statement saying that we strongly discourage it, I guess. Maxime
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index 459cb63..c4d4c73 100644 --- a/arch/arm/boot/dts/sun4i-a10.dtsi +++ b/arch/arm/boot/dts/sun4i-a10.dtsi @@ -81,6 +81,14 @@ clock-output-names = "pll1"; }; + pll2: clk@01c20008 { + #clock-cells = <1>; + compatible = "allwinner,sun4i-a10-b-pll2-clk"; + reg = <0x01c20008 0x4>; + clocks = <&osc24M>; + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; + }; + pll4: clk@01c20018 { #clock-cells = <0>; compatible = "allwinner,sun4i-a10-pll1-clk"; diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi index 24b0ad3..f35aa4d 100644 --- a/arch/arm/boot/dts/sun5i-a10s.dtsi +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi @@ -74,6 +74,14 @@ clock-output-names = "pll1"; }; + pll2: clk@01c20008 { + #clock-cells = <1>; + compatible = "allwinner,sun4i-a10-b-pll2-clk"; + reg = <0x01c20008 0x4>; + clocks = <&osc24M>; + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; + }; + pll4: clk@01c20018 { #clock-cells = <0>; compatible = "allwinner,sun4i-a10-pll1-clk"; diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi index bf86e65..38b2d77 100644 --- a/arch/arm/boot/dts/sun5i-a13.dtsi +++ b/arch/arm/boot/dts/sun5i-a13.dtsi @@ -75,6 +75,14 @@ clock-output-names = "pll1"; }; + pll2: clk@01c20008 { + #clock-cells = <1>; + compatible = "allwinner,sun4i-a10-b-pll2-clk"; + reg = <0x01c20008 0x4>; + clocks = <&osc24M>; + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; + }; + pll4: clk@01c20018 { #clock-cells = <0>; compatible = "allwinner,sun4i-a10-pll1-clk"; diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 4011628..7a6a18c 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -91,6 +91,14 @@ clock-output-names = "pll1"; }; + pll2: clk@01c20008 { + #clock-cells = <1>; + compatible = "allwinner,sun4i-a10-b-pll2-clk"; + reg = <0x01c20008 0x4>; + clocks = <&osc24M>; + clock-output-names = "pll2", "pll2x2", "pll2x4", "pll2x8"; + }; + pll4: clk@01c20018 { #clock-cells = <0>; compatible = "allwinner,sun7i-a20-pll4-clk";
This commit adds the PLL2 definition to the sun4i, sun5i and sun7i device trees. PLL2 is used to clock audio devices. Signed-off-by: Emilio López <emilio@elopez.com.ar> --- Changes from RFC: * A10 rev A is now supported via the quirk code arch/arm/boot/dts/sun4i-a10.dtsi | 8 ++++++++ arch/arm/boot/dts/sun5i-a10s.dtsi | 8 ++++++++ arch/arm/boot/dts/sun5i-a13.dtsi | 8 ++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++ 4 files changed, 32 insertions(+)