diff mbox

[U-Boot,1/3] cm-t54: fix EEPROM read return value check

Message ID 1406806241-16813-2-git-send-email-lifshitz@compulab.co.il
State Awaiting Upstream
Delegated to: Tom Rini
Headers show

Commit Message

Dmitry Lifshitz July 31, 2014, 11:30 a.m. UTC
Fix cl_eeprom_read_mac_addr() return value check.
Fix long line codding style issue in board_init().

Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
---
 board/compulab/cm_t54/cm_t54.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini Aug. 25, 2014, 7:17 p.m. UTC | #1
On Thu, Jul 31, 2014 at 02:30:39PM +0300, Dmitry Lifshitz wrote:

> Fix cl_eeprom_read_mac_addr() return value check.
> Fix long line codding style issue in board_init().
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>

Applied to u-boot-ti/master, thanks!
diff mbox

Patch

diff --git a/board/compulab/cm_t54/cm_t54.c b/board/compulab/cm_t54/cm_t54.c
index fadfddc..306491b 100644
--- a/board/compulab/cm_t54/cm_t54.c
+++ b/board/compulab/cm_t54/cm_t54.c
@@ -43,7 +43,7 @@  const struct omap_sysinfo sysinfo = {
  */
 int board_init(void)
 {
-	gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100); /* boot param addr */
+	gd->bd->bi_boot_params = (CONFIG_SYS_SDRAM_BASE + 0x100);
 
 	return 0;
 }
@@ -169,7 +169,7 @@  static int handle_mac_address(void)
 		return 0;
 
 	ret = cl_eeprom_read_mac_addr(enetaddr);
-	if (!ret || !is_valid_ether_addr(enetaddr))
+	if (ret || !is_valid_ether_addr(enetaddr))
 		generate_mac_addr(enetaddr);
 
 	if (!is_valid_ether_addr(enetaddr))