From patchwork Tue Nov 3 10:16:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 37499 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D5754B7BE3 for ; Tue, 3 Nov 2009 21:17:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbZKCKR1 (ORCPT ); Tue, 3 Nov 2009 05:17:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753026AbZKCKR0 (ORCPT ); Tue, 3 Nov 2009 05:17:26 -0500 Received: from gw1.cosmosbay.com ([212.99.114.194]:57084 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbZKCKRZ (ORCPT ); Tue, 3 Nov 2009 05:17:25 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by gw1.cosmosbay.com (8.13.7/8.13.7) with ESMTP id nA3AHRFm023331; Tue, 3 Nov 2009 11:17:27 +0100 Message-ID: <4AF0031B.4060708@gmail.com> Date: Tue, 03 Nov 2009 11:16:59 +0100 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: David Miller CC: ebiederm@xmission.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: Support specifying the network namespace upon device creation. References: <4AEFF7BB.4090301@gmail.com> <20091103.020555.156050455.davem@davemloft.net> In-Reply-To: <20091103.020555.156050455.davem@davemloft.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Tue, 03 Nov 2009 11:17:27 +0100 (CET) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org David Miller a écrit : > It can also be argued that for functions, wrapping the args is > worse because it makes grep output less useful. In fact that's, > I believe, Linus's most recent recommendation in this area :) Yes, true. One thing I usually miss is the { next to "struct some_name" declarations, to ease games based on "grep" Would you accept one boring cleanup patch in include/net like following ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/net/route.h b/include/net/route.h index 40f6346..1524b75 100644 --- a/include/net/route.h +++ b/include/net/route.h @@ -49,8 +49,7 @@ struct fib_nh; struct inet_peer; -struct rtable -{ +struct rtable { union { struct dst_entry dst; @@ -77,16 +76,14 @@ struct rtable struct inet_peer *peer; /* long-living peer info */ }; -struct ip_rt_acct -{ +struct ip_rt_acct { __u32 o_bytes; __u32 o_packets; __u32 i_bytes; __u32 i_packets; }; -struct rt_cache_stat -{ +struct rt_cache_stat { unsigned int in_hit; unsigned int in_slow_tot; unsigned int in_slow_mc;