Patchwork net: Support specifying the network namespace upon device creation.

login
register
mail settings
Submitter Eric Dumazet
Date Nov. 3, 2009, 10:16 a.m.
Message ID <4AF0031B.4060708@gmail.com>
Download mbox | patch
Permalink /patch/37499/
State RFC
Delegated to: David Miller
Headers show

Comments

Eric Dumazet - Nov. 3, 2009, 10:16 a.m.
David Miller a écrit :

> It can also be argued that for functions, wrapping the args is
> worse because it makes grep output less useful.  In fact that's,
> I believe, Linus's most recent recommendation in this area :)

Yes, true.

One thing I usually miss is the { next to "struct some_name" declarations,
to ease games based on "grep" 

Would you accept one boring cleanup patch in include/net like following ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 3, 2009, 10:44 a.m.
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 03 Nov 2009 11:16:59 +0100

> David Miller a écrit :
> 
>> It can also be argued that for functions, wrapping the args is
>> worse because it makes grep output less useful.  In fact that's,
>> I believe, Linus's most recent recommendation in this area :)
> 
> Yes, true.
> 
> One thing I usually miss is the { next to "struct some_name" declarations,
> to ease games based on "grep" 
> 
> Would you accept one boring cleanup patch in include/net like following ?

Absolutely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/net/route.h b/include/net/route.h
index 40f6346..1524b75 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -49,8 +49,7 @@ 
 
 struct fib_nh;
 struct inet_peer;
-struct rtable
-{
+struct rtable {
 	union
 	{
 		struct dst_entry	dst;
@@ -77,16 +76,14 @@  struct rtable
 	struct inet_peer	*peer; /* long-living peer info */
 };
 
-struct ip_rt_acct
-{
+struct ip_rt_acct {
 	__u32 	o_bytes;
 	__u32 	o_packets;
 	__u32 	i_bytes;
 	__u32 	i_packets;
 };
 
-struct rt_cache_stat 
-{
+struct rt_cache_stat {
         unsigned int in_hit;
         unsigned int in_slow_tot;
         unsigned int in_slow_mc;