From patchwork Tue Nov 3 08:38:25 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: vimal singh X-Patchwork-Id: 37491 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A7E99B7C29 for ; Tue, 3 Nov 2009 19:40:56 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N5Eui-00008P-J2; Tue, 03 Nov 2009 08:38:52 +0000 Received: from mail-bw0-f212.google.com ([209.85.218.212]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N5Eub-00006w-S8 for linux-mtd@lists.infradead.org; Tue, 03 Nov 2009 08:38:50 +0000 Received: by bwz4 with SMTP id 4so7626620bwz.2 for ; Tue, 03 Nov 2009 00:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=aBceDllpUuPVkFsqjLgunZlUL0foVp3BqxGRtnsFzs4=; b=OmtmLfKa21GjAUcrVpR6qwOQYA3cpgXulkBF0sP6YmxKCdRQbuRLYVIGl4WB1P0AoA W7+ded1etn2EeYOO8d1+yVJUc330Tx3gT6dK0/6NKQYPzaM4r3aPy7LDeXQxdMBg4xM1 Tj9dHED923QTtPVR/X0ZVbogKmWuq454C1AU4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=ItGA68Uluz8koo2Gf8Bww5Pv7lu/LYSYr0f6THj+fC9xyK1wppXwhArLNHIfPn3PLK SCjUASZ/lFL2SAOd3RHr4pW18YlBarKQzAFoAwwJMzU/E3folZbG6uo2XvSZ/LgIROV8 0V/0qmUDqcr52tYfg9ZgTPBTyqWzJMdfiClFY= MIME-Version: 1.0 Received: by 10.204.3.19 with SMTP id 19mr4598338bkl.151.1257237525126; Tue, 03 Nov 2009 00:38:45 -0800 (PST) In-Reply-To: <1257236323.21596.56.camel@localhost> References: <1257236323.21596.56.camel@localhost> From: Vimal Singh Date: Tue, 3 Nov 2009 14:08:25 +0530 Message-ID: Subject: Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c' To: dedekind1@gmail.com X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091103_033846_353040_FE023257 X-CRM114-Status: GOOD ( 15.33 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ Cc: linux-omap@vger.kernel.org, Linux MTD X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy wrote: > On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote: >> Looping Linux-omap mailing list. >> >> >> From: Vimal Singh >> Date: Fri, 30 Oct 2009 11:31:34 +0530 >> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' >> >> Fixing below warning in compilation: >> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': >> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of >> 'omap_nand_dma_transfer' discards qualifiers from pointer target type >> >> Signed-off-by: Vimal Singh >> --- >>  drivers/mtd/nand/omap2.c |    6 ++++-- >>  1 files changed, 4 insertions(+), 2 deletions(-) > > [dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal > ERROR: patch seems to be corrupt (line wrapped?) > #94: FILE: drivers/mtd/nand/omap2.c:500: > mtd_info *mtd, u_char *buf, int len) > > total: 1 errors, 0 warnings, 16 lines checked > > vimal has style problems, please review.  If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > [dedekind@eru l2-mtd-2.6.git]$ vim vimal > [dedekind@eru l2-mtd-2.6.git]$ git am vimal > Applying: Fixing compilation warning for 'nand/omap2.c' > fatal: corrupt patch at line 10 > Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c' > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching run "git am --abort". > [dedekind@eru l2-mtd-2.6.git]$ > Grr... its again mailer's issue. Fixed this in below patch: -vimal From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001 From: Vimal Singh Date: Fri, 30 Oct 2009 11:31:34 +0530 Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c' Fixing below warning in compilation: drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref': drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of 'omap_nand_dma_transfer' discards qualifiers from pointer target type Signed-off-by: Vimal Singh --- drivers/mtd/nand/omap2.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) /** diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 090ab87..92573d5 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct mtd_info *mtd, u_char static void omap_write_buf_dma_pref(struct mtd_info *mtd, const u_char *buf, int len) { + u_char *p = (u_char *)buf; + if (len <= mtd->oobsize) - omap_write_buf_pref(mtd, buf, len); + omap_write_buf_pref(mtd, p, len); else /* start transfer in DMA mode */ - omap_nand_dma_transfer(mtd, buf, len, 0x1); + omap_nand_dma_transfer(mtd, p, len, 0x1); }