From patchwork Tue Nov 3 06:02:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin O'Connor X-Patchwork-Id: 37487 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 93ABEB7C2C for ; Tue, 3 Nov 2009 17:03:13 +1100 (EST) Received: from localhost ([127.0.0.1]:42768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5CU2-0007J2-Gz for incoming@patchwork.ozlabs.org; Tue, 03 Nov 2009 01:03:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5CTP-0007GL-ND for qemu-devel@nongnu.org; Tue, 03 Nov 2009 01:02:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5CTK-0007BB-Ob for qemu-devel@nongnu.org; Tue, 03 Nov 2009 01:02:31 -0500 Received: from [199.232.76.173] (port=48519 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5CTK-0007Ay-K9 for qemu-devel@nongnu.org; Tue, 03 Nov 2009 01:02:26 -0500 Received: from imta-38.everyone.net ([216.200.145.38]:51184 helo=omta0110.mta.everyone.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5CTK-00075e-0J for qemu-devel@nongnu.org; Tue, 03 Nov 2009 01:02:26 -0500 Received: from dm0206.mta.everyone.net (sj1-slb03-gw2 [172.16.1.96]) by omta0110.mta.everyone.net (Postfix) with ESMTP id 8768B639ADF; Mon, 2 Nov 2009 22:02:24 -0800 (PST) X-Eon-Dm: dm0206 Received: by dm0206.mta.everyone.net (EON-AUTHRELAY2 - cfedc2a1) id dm0206.4aedf9b3.370737; Mon, 2 Nov 2009 22:02:24 -0800 X-Eon-Sig: AQHOS7NK78dwvi4SNAIAAAAD,c5074b2e135e0f80d6be1b5c1e455a9b Date: Tue, 3 Nov 2009 01:02:23 -0500 From: Kevin O'Connor To: Avi Kivity Subject: Re: [Qemu-devel] PC machine types switched to SeaBIOS/gPXE Message-ID: <20091103060223.GB13492@morn.localdomain> References: <4AEAFE39.1030302@us.ibm.com> <4AEED5EC.8000406@suse.de> <4AEED9D8.2020307@redhat.com> <4AEEDB75.3090100@suse.de> <4AEEDF86.7080009@redhat.com> <20091102135107.GA9856@morn.localdomain> <4AEEE4F8.1020409@redhat.com> <20091103045056.GA13246@morn.localdomain> <6C88F564-1E98-4F82-90F8-99F390927042@suse.de> <4AEFB940.1020201@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4AEFB940.1020201@redhat.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: "qemu-devel@nongnu.org" , Gleb Natapov X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Tue, Nov 03, 2009 at 07:01:52AM +0200, Avi Kivity wrote: > That works too, but if firmware config can use rep/ins, that's one less > interface we have to add. The following patch to seabios seems to work. I'm not sure if there are any special implications to qemu. -Kevin --- a/src/paravirt.c +++ b/src/paravirt.c @@ -23,8 +23,7 @@ qemu_cfg_select(u16 f) static void qemu_cfg_read(u8 *buf, int len) { - while (len--) - *(buf++) = inb(PORT_QEMU_CFG_DATA); + insb(PORT_QEMU_CFG_DATA, buf, len); } static void