From patchwork Mon Nov 2 23:45:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Anders X-Patchwork-Id: 37463 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4D665B7C21 for ; Tue, 3 Nov 2009 11:19:31 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757348AbZKCATP (ORCPT ); Mon, 2 Nov 2009 19:19:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757336AbZKCATO (ORCPT ); Mon, 2 Nov 2009 19:19:14 -0500 Received: from metropolitan.anduras.de ([80.237.200.159]:45060 "EHLO metropolitan.anduras.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756940AbZKCATO (ORCPT ); Mon, 2 Nov 2009 19:19:14 -0500 X-Greylist: delayed 2031 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Nov 2009 19:19:13 EST Received: from popper.anduras.office (p5491876B.dip0.t-ipconnect.de [84.145.135.107]) (Authenticated sender: anduras@anduras.priv) by metropolitan.anduras.de (Postfix) with ESMTP id E489B1E546E; Tue, 3 Nov 2009 00:45:26 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by popper.anduras.office (Postfix) with ESMTP id 570EA2140A5; Tue, 3 Nov 2009 00:45:26 +0100 (CET) Received: from popper.anduras.office ([127.0.0.1]) by localhost (popper.anduras.office [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 22943-02; Tue, 3 Nov 2009 00:45:26 +0100 (CET) Received: from [192.168.10.15] (suburban.anduras.office [10.10.20.242]) by popper.anduras.office (Postfix) with ESMTP id 7F80A214001; Tue, 3 Nov 2009 00:45:25 +0100 (CET) Message-ID: <4AEF6F14.7080802@anduras.de> Date: Tue, 03 Nov 2009 00:45:24 +0100 From: Sven Anders Organization: ANDURAS AG User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: netdev CC: shemminger@vyatta.com Subject: Bugfix for iproute2 X-Enigmail-Version: 0.95.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! I already send this mail to Stephen Hemminger, but I'm not sure if it reached him. Moreover I tried to join the LARTC mailing list (http://mailman.ds9a.nl/mailman/listinfo/lartc) but it did not work. Is this mailing list dead? Therefore I sent this mail again over this mailing list... I experienced an error, if I try to perform a ip route flush proto 4 with many routes in a complex environment, it gave me the following error: Failed to send flush request: Success Flush terminated I'm using version 2.6.29. I check GIT, but there was only the "MSG_PEEK" fix. I tracked it down to the rtnl_send_check() function in lib/libnetlink.c. In this function there is the following for loop: for (h = (struct nlmsghdr *)resp; NLMSG_OK(h, status); h = NLMSG_NEXT(h, status)) { if (h->nlmsg_type == NLMSG_ERROR) { struct nlmsgerr *err = (struct nlmsgerr*)NLMSG_DATA(h); if (h->nlmsg_len < NLMSG_LENGTH(sizeof(struct nlmsgerr))) fprintf(stderr, "ERROR truncated\n"); else errno = -err->error; } return -1; } I think the "return -1;" should be inside the if statement. I attached a patch for this. The first part of the patch is taken from one of the late git commits. Please note me, if the fix is wrong... Regards Sven Anders --- iproute2-2.6.29/lib/libnetlink.c.orig 2009-09-23 14:47:03.000000000 +0200 +++ iproute2-2.6.29/lib/libnetlink.c 2009-09-23 14:48:09.000000000 +0200 @@ -122,7 +122,7 @@ int rtnl_send_check(struct rtnl_handle * return status; /* Check for errors */ - status = recv(rth->fd, resp, sizeof(resp), MSG_DONTWAIT); + status = recv(rth->fd, resp, sizeof(resp), MSG_DONTWAIT|MSG_PEEK); if (status < 0) { if (errno == EAGAIN) return 0; @@ -137,8 +137,8 @@ int rtnl_send_check(struct rtnl_handle * fprintf(stderr, "ERROR truncated\n"); else errno = -err->error; - } return -1; + } } return 0;